Fix failing test (2)

elastic · Aug 19, 2020 · d62f9a7 · d62f9a7
1 parent a95c282
commit d62f9a7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/plugins/es_ui_shared/public/forms/form_wizard/form_wizard_context.tsx b/src/plugins/es_ui_shared/public/forms/form_wizard/form_wizard_context.tsx
@@ -147,7 +147,7 @@ export const FormWizardProvider = WithMultiContent<Props<any>>(function FormWiza
  return nextState;
  });
  },
- [getStepIndex, validate, onSave, getData]
+ [getStepIndex, validate, onSave, getData, lastStep]
  );
 
  const value: Context = {

diff --git a/...ins/index_management/public/application/components/mappings_editor/use_state_listener.tsx b/...ins/index_management/public/application/components/mappings_editor/use_state_listener.tsx
@@ -29,15 +29,14 @@ export const useMappingsStateListener = ({ onChange, value }: Args) => {
  const dispatch = useDispatch();
 
  const parsedFieldsDefaultValue = useMemo(() => normalize(value?.fields), [value?.fields]);
-
  useEffect(() => {
  // If we are creating a new field, but haven't entered any name
  // it is valid and we can byPass its form validation (that requires a "name" to be defined)
  const isFieldFormVisible = state.fieldForm !== undefined;
  const emptyNameValue =
  isFieldFormVisible &&
- state.fieldForm!.data.raw.name !== undefined &&
- state.fieldForm!.data.raw.name.trim() === '';
+ (state.fieldForm!.data.raw.name === undefined ||
+  state.fieldForm!.data.raw.name.trim() === '');
 
  const bypassFieldFormValidation =
  state.documentFields.status === 'creatingField' && emptyNameValue;