Skip to content

Commit

Permalink
[8.15] [Links] Fix positioning of dragged link in links editor (#189122
Browse files Browse the repository at this point in the history
…) (#189129)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Links] Fix positioning of dragged link in links editor
(#189122)](#189122)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nick
Peihl","email":"nick.peihl@elastic.co"},"sourceCommit":{"committedDate":"2024-07-24T19:49:43Z","message":"[Links]
Fix positioning of dragged link in links editor (#189122)\n\n##
Summary\r\n\r\nFixes positioning of dragged links in the Links panel
editor.\r\n\r\nThe issue was caused by the `transform: translateZ(0)`
workaround in EUI\r\nto fix a [mask image
bug](elastic/eui#7855) in\r\nChromium. We fix
this by overriding the `transform` for in the\r\n`FlyoutBody` of the
Links panel
editor.\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8ad10732-dfaa-4464-845b-0a9c4fc6b173\r\n\r\nAfter:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e6f0bffe-7eb0-4590-affc-a89bc86b973d","sha":"e566abf1cb6317c381431c4902abd5554fea6217","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v8.15.0","v8.16.0"],"title":"[Links]
Fix positioning of dragged link in links
editor","number":189122,"url":"https://github.com/elastic/kibana/pull/189122","mergeCommit":{"message":"[Links]
Fix positioning of dragged link in links editor (#189122)\n\n##
Summary\r\n\r\nFixes positioning of dragged links in the Links panel
editor.\r\n\r\nThe issue was caused by the `transform: translateZ(0)`
workaround in EUI\r\nto fix a [mask image
bug](elastic/eui#7855) in\r\nChromium. We fix
this by overriding the `transform` for in the\r\n`FlyoutBody` of the
Links panel
editor.\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8ad10732-dfaa-4464-845b-0a9c4fc6b173\r\n\r\nAfter:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e6f0bffe-7eb0-4590-affc-a89bc86b973d","sha":"e566abf1cb6317c381431c4902abd5554fea6217"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189122","number":189122,"mergeCommit":{"message":"[Links]
Fix positioning of dragged link in links editor (#189122)\n\n##
Summary\r\n\r\nFixes positioning of dragged links in the Links panel
editor.\r\n\r\nThe issue was caused by the `transform: translateZ(0)`
workaround in EUI\r\nto fix a [mask image
bug](elastic/eui#7855) in\r\nChromium. We fix
this by overriding the `transform` for in the\r\n`FlyoutBody` of the
Links panel
editor.\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8ad10732-dfaa-4464-845b-0a9c4fc6b173\r\n\r\nAfter:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e6f0bffe-7eb0-4590-affc-a89bc86b973d","sha":"e566abf1cb6317c381431c4902abd5554fea6217"}}]}]
BACKPORT-->

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
  • Loading branch information
kibanamachine and nickpeihl authored Jul 24, 2024
1 parent c139f23 commit d6c1564
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/plugins/links/public/components/editor/links_editor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,12 @@ const LinksEditor = ({
</EuiFlexItem>
</EuiFlexGroup>
</EuiFlyoutHeader>
<EuiFlyoutBody>
<EuiFlyoutBody
// EUI TODO: We need to set transform to 'none' to avoid drag/drop issues in the flyout caused by the
// `transform: translateZ(0)` workaround for the mask image bug in Chromium.
// https://github.com/elastic/eui/pull/7855.
css={{ '.euiFlyoutBody__overflow': { transform: 'none' } }}
>
<EuiForm fullWidth>
<EuiFormRow label={LinksStrings.editor.panelEditor.getLayoutSettingsTitle()}>
<EuiButtonGroup
Expand Down

0 comments on commit d6c1564

Please sign in to comment.