address comments

elastic · Jun 13, 2023 · d6da91a · d6da91a
1 parent a0cca84
commit d6da91a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/...n/public/detection_engine/rule_exceptions/components/add_exception_flyout/translations.ts b/...n/public/detection_engine/rule_exceptions/components/add_exception_flyout/translations.ts
@@ -89,6 +89,6 @@ export const ADD_RULE_EXCEPTION_FROM_ALERT_COMMENT = (alertId: string) =>
     'xpack.securitySolution.ruleExceptions.addExceptionFlyout.addRuleExceptionFromAlertComment',
     {
       values: { alertId },
-      defaultMessage: 'Exception conditions are pre-filled with relevant data from {alertId}',
+      defaultMessage: 'Exception conditions are pre-filled with relevant data from {alertId}.',
     }
   );
diff --git a/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/utils/helpers.tsx b/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/utils/helpers.tsx
@@ -780,7 +780,6 @@ export const defaultEndpointExceptionItems = (
 ): ExceptionsBuilderExceptionItem[] => {
   const eventCode = alertEcsData['event.code'] ?? alertEcsData.event?.code;
 
-  // TODO EventCode can be used from '@kbn/securitysolution-ecs';
   switch (eventCode) {
     case 'behavior':
       return [

diff --git a/...urity_solution/public/detection_engine/rule_exceptions/utils/highlighted_fields_config.ts b/...urity_solution/public/detection_engine/rule_exceptions/utils/highlighted_fields_config.ts
@@ -5,6 +5,12 @@
  * 2.0.
  */
 
+/**
+ * The highlightedFieldsPrefixToExclude is an array of prefixes
+ * that should be disregarded in the Rule Exception.These prefixes
+ * are irrelevant to the exception and should be ignored,even if
+ * they were retrieved as Highlighted Fields from the "getEventFieldsToDisplay".
+ */
 export const highlightedFieldsPrefixToExclude = ['kibana.alert.rule', 'signal.rule', 'rule'];
 
 export const getKibanaAlertIdField = (id: string) => `kibana.alert.${id}`;