-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Controls] Persist
runPastTimeout
setting (#208611)
Closes #206459 ## Summary This PR ensures that the `runPastTimeout` setting is persisted for options list controls and the UI reflects the value of this setting. The root cause of this bug is that we weren't sending in the behavior subject for `runPastTimeout$` to the data control's `editorStateManager` when initializing the options list control, which meant that its value could not be set by the options list's `CustomOptionsComponent` - this PR fixes that. **Before** https://github.com/user-attachments/assets/2c9eeab8-67d9-46bc-938e-4d7cb91e435f **After** https://github.com/user-attachments/assets/d06b6ffa-b1e9-4ecd-b732-69bd69a8aee9 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- Loading branch information
Showing
3 changed files
with
77 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters