Incorporating reviewer feedback.

elastic · Sep 1, 2020 · dfc4b4f · dfc4b4f
1 parent 9145874
commit dfc4b4f
Show file tree

Hide file tree

Showing 10 changed files with 19 additions and 38 deletions.
diff --git a/...mponents/pipeline_processors_editor/components/manage_processor_form/processors/bytes.tsx b/...mponents/pipeline_processors_editor/components/manage_processor_form/processors/bytes.tsx
@@ -24,15 +24,7 @@ export const Bytes: FunctionComponent = () => {
  )}
  />
 
- <TargetField
- helpText={i18n.translate(
- 'xpack.ingestPipelines.pipelineEditor.convertForm.targetFieldHelpText',
- {
- defaultMessage:
- 'Field to assign the converted value to. Defaults to the specified field name.',
- }
- )}
- />
+ <TargetField />
 
  <IgnoreMissingField />
  </>

diff --git a/...ponents/pipeline_processors_editor/components/manage_processor_form/processors/circle.tsx b/...ponents/pipeline_processors_editor/components/manage_processor_form/processors/circle.tsx
@@ -39,7 +39,7 @@ const fieldsConfig: FieldsConfig = {
  helpText: () => (
  <FormattedMessage
  id="xpack.ingestPipelines.pipelineEditor.circleForm.errorDistanceHelpText"
- defaultMessage="Difference between the side of the inscribed shape to the encompassing circle. Measured in meters for {geo_shape}, but uses no units for {shape}."
+ defaultMessage="Difference between the side of the inscribed shape to the encompassing circle. Determines the accuracy of the output polygon. Measured in meters for {geo_shape}, but uses no units for {shape}."
  values={{
  geo_shape: <EuiCode>{'geo_shape'}</EuiCode>,
  shape: <EuiCode>{'shape'}</EuiCode>,
@@ -71,7 +71,7 @@ const fieldsConfig: FieldsConfig = {
  }),
  helpText: i18n.translate(
  'xpack.ingestPipelines.pipelineEditor.circleForm.shapeTypeFieldHelpText',
- { defaultMessage: 'Field mapping type to use when processing the circle.' }
+ { defaultMessage: 'Field mapping type to use when processing the output polygon.' }
  ),
  validations: [
  {

diff --git a/...tor/components/manage_processor_form/processors/common_fields/common_processor_fields.tsx b/...tor/components/manage_processor_form/processors/common_fields/common_processor_fields.tsx
@@ -40,7 +40,7 @@ const ifConfig: FieldConfig = {
  defaultMessage: 'Condition (optional)',
  }),
  helpText: i18n.translate('xpack.ingestPipelines.pipelineEditor.commonFields.ifFieldHelpText', {
- defaultMessage: 'Conditional statement to run with this processor.',
+ defaultMessage: 'Conditionally run this processor.',
  }),
  type: FIELD_TYPES.TEXT,
 };

diff --git a/...cessors_editor/components/manage_processor_form/processors/common_fields/target_field.tsx b/...cessors_editor/components/manage_processor_form/processors/common_fields/target_field.tsx
@@ -21,8 +21,7 @@ const fieldsConfig: FieldsConfig = {
  helpText: i18n.translate(
  'xpack.ingestPipelines.pipelineEditor.commonFields.targetFieldHelpText',
  {
- defaultMessage:
- 'Field to assign the joined value to. If empty, the field is updated in place.',
+ defaultMessage: 'Output field. If empty, the input field is updated in place.',
  }
  ),
  },

diff --git a/...onents/pipeline_processors_editor/components/manage_processor_form/processors/convert.tsx b/...onents/pipeline_processors_editor/components/manage_processor_form/processors/convert.tsx
@@ -115,15 +115,7 @@ export const Convert: FunctionComponent = () => {
  path="fields.type"
  />
 
- <TargetField
- helpText={i18n.translate(
- 'xpack.ingestPipelines.pipelineEditor.convertForm.targetFieldHelpText',
- {
- defaultMessage:
- 'Field to assign the converted value to. Defaults to the specified field name.',
- }
- )}
- />
+ <TargetField />
 
  <IgnoreMissingField />
  </>

diff --git a/...components/pipeline_processors_editor/components/manage_processor_form/processors/csv.tsx b/...components/pipeline_processors_editor/components/manage_processor_form/processors/csv.tsx
@@ -52,7 +52,7 @@ const fieldsConfig: FieldsConfig = {
  defaultMessage: 'Target fields',
  }),
  helpText: i18n.translate('xpack.ingestPipelines.pipelineEditor.csvForm.targetFieldsHelpText', {
- defaultMessage: 'Array of fields to assign extracted values to.',
+ defaultMessage: 'Output fields. Extracted values are mapped to these fields.',
  }),
  validations: [
  {
@@ -83,7 +83,7 @@ const fieldsConfig: FieldsConfig = {
  helpText: (
  <FormattedMessage
  id="xpack.ingestPipelines.pipelineEditor.convertForm.separatorHelpText"
- defaultMessage="Single character string used to separate data. Defaults to {value}."
+ defaultMessage="Delimiter used in the CSV data. Defaults to {value}."
  values={{ value: <EuiCode inline>{','}</EuiCode> }}
  />
  ),
@@ -102,7 +102,7 @@ const fieldsConfig: FieldsConfig = {
  helpText: (
  <FormattedMessage
  id="xpack.ingestPipelines.pipelineEditor.convertForm.quoteHelpText"
- defaultMessage="Single character string used to separate data. Defaults to {value}."
+ defaultMessage="Escape character used in the CSV data. Defaults to {value}."
  values={{ value: <EuiCode inline>{'"'}</EuiCode> }}
  />
  ),
@@ -115,7 +115,7 @@ const fieldsConfig: FieldsConfig = {
  defaultMessage: 'Trim',
  }),
  helpText: i18n.translate('xpack.ingestPipelines.pipelineEditor.csvForm.trimFieldHelpText', {
- defaultMessage: 'Trim whitespaces in unquoted fields.',
+ defaultMessage: 'Remove whitespaces in unquoted CSV data.',
  }),
  },
  empty_value: {
@@ -127,7 +127,7 @@ const fieldsConfig: FieldsConfig = {
  'xpack.ingestPipelines.pipelineEditor.convertForm.emptyValueFieldHelpText',
  {
  defaultMessage:
- 'Value used to fill empty fields. Empty fields are skipped if this value is not provided.',
+ 'Used to fill empty fields. If no value is provided, empty fields are skipped.',
  }
  ),
  },

diff --git a/...omponents/pipeline_processors_editor/components/manage_processor_form/processors/date.tsx b/...omponents/pipeline_processors_editor/components/manage_processor_form/processors/date.tsx
@@ -33,7 +33,7 @@ const fieldsConfig: FieldsConfig = {
  }),
  helpText: i18n.translate('xpack.ingestPipelines.pipelineEditor.dateForm.formatsFieldHelpText', {
  defaultMessage:
- 'Array of the expected date formats. Accepts a Java time pattern, ISO8601, UNIX, UNIX_MS, or TAI64N formats.',
+ 'Expected date formats. Provided formats are applied sequentially. Accepts a Java time pattern, ISO8601, UNIX, UNIX_MS, or TAI64N formats.',
  }),
  validations: [
  {
@@ -99,7 +99,7 @@ export const DateProcessor: FunctionComponent = () => {
  helpText={
  <FormattedMessage
  id="xpack.ingestPipelines.pipelineEditor.dateForm.targetFieldHelpText"
- defaultMessage="Field that will hold the parsed date. Defaults to {defaultField}."
+ defaultMessage="Output field. If empty, the input field is updated in place. Defaults to {defaultField}."
  values={{
  defaultField: <EuiCode inline>{'@timestamp'}</EuiCode>,
  }}

diff --git a/...onents/pipeline_processors_editor/components/manage_processor_form/processors/dissect.tsx b/...onents/pipeline_processors_editor/components/manage_processor_form/processors/dissect.tsx
@@ -79,7 +79,7 @@ const getFieldsConfig = (esDocUrl: string): Record<string, FieldConfig> => {
  helpText: (
  <FormattedMessage
  id="xpack.ingestPipelines.pipelineEditor.dissectForm.appendSeparatorHelpText"
- defaultMessage="Characters used to separate fields when appending two or more results together. Defaults to {value}."
+ defaultMessage="If you specify a key modifier, this character separates the fields when appending results. Defaults to {value}."
  values={{ value: <EuiCode inline>{'""'}</EuiCode> }}
  />
  ),

diff --git a/...s/pipeline_processors_editor/components/manage_processor_form/processors/dot_expander.tsx b/...s/pipeline_processors_editor/components/manage_processor_form/processors/dot_expander.tsx
@@ -19,7 +19,7 @@ const fieldsConfig: Record<string, FieldConfig> = {
  }),
  helpText: i18n.translate('xpack.ingestPipelines.pipelineEditor.dotExpanderForm.pathHelpText', {
  defaultMessage:
- 'Field containing the object to expand. Only required if the field to expand is part another object field.',
+ 'Output field. Only required if the field to expand is part another object field.',
  }),
  },
 };

diff --git a/...on/components/pipeline_processors_editor/components/shared/map_processor_type_to_form.tsx b/...on/components/pipeline_processors_editor/components/shared/map_processor_type_to_form.tsx
@@ -75,8 +75,7 @@ export const mapProcessorTypeToDescriptor: MapProcessorTypeToDescriptor = {
  defaultMessage: 'Circle',
  }),
  description: i18n.translate('xpack.ingestPipelines.processors.description.circle', {
- defaultMessage:
- 'Converts circle definitions of shapes to regular polygons that approximate them. The error distance determines the accuracy of the polygon that represents the circle.',
+ defaultMessage: 'Converts a circle definition into an approximate polygon.',
  }),
  },
  convert: {
@@ -97,7 +96,7 @@ export const mapProcessorTypeToDescriptor: MapProcessorTypeToDescriptor = {
  defaultMessage: 'CSV',
  }),
  description: i18n.translate('xpack.ingestPipelines.processors.description.csv', {
- defaultMessage: 'Extracts fields from a CSV line in a single text field within a document.',
+ defaultMessage: 'Extracts fields values from CSV data.',
  }),
  },
  date: {
@@ -118,7 +117,7 @@ export const mapProcessorTypeToDescriptor: MapProcessorTypeToDescriptor = {
  }),
  description: i18n.translate('xpack.ingestPipelines.processors.description.dateIndexName', {
  defaultMessage:
- 'Points documents to the correct time-based index, based on a date or timestamp field in a document using the date math support in index names.',
+ 'Uses a date or timestamp to add documents to the correct time-based index. Index names must use a date math pattern, such as my-index-yyyy-MM-dd.',
  }),
  },
  dissect: {
@@ -128,8 +127,7 @@ export const mapProcessorTypeToDescriptor: MapProcessorTypeToDescriptor = {
  defaultMessage: 'Dissect',
  }),
  description: i18n.translate('xpack.ingestPipelines.processors.description.dissect', {
- defaultMessage:
- 'Matches a single text field against a defined pattern to extract structured fields within a document.',
+ defaultMessage: 'Uses dissect patterns to extract matches from a field.',
  }),
  },
  dot_expander: {