fix possible side effect

elastic · Oct 26, 2022 · e09574a · e09574a
1 parent 251a42e
commit e09574a
Showing 1 changed file with 13 additions and 3 deletions.
diff --git a/x-pack/plugins/security_solution/public/common/components/guided_onboarding_tour/tour.tsx b/x-pack/plugins/security_solution/public/common/components/guided_onboarding_tour/tour.tsx
@@ -6,7 +6,7 @@
  */
 
 import type { ReactChild } from 'react';
-import React, { createContext, useCallback, useContext, useMemo, useState } from 'react';
+import React, { createContext, useCallback, useContext, useEffect, useMemo, useState } from 'react';
 
 import useObservable from 'react-use/lib/useObservable';
 import { catchError, of, timeout } from 'rxjs';
@@ -81,12 +81,22 @@ export const RealTourContextProvider = ({ children }: { children: ReactChild })
   //   // guidedOnboardingApi.idkSetStepTo(stepId, 'active')
   // }, []);
 
+  const [isMounted, setIsMounted] = useState(true);
+
+  useEffect(() => {
+    return () => {
+      setIsMounted(false);
+    };
+  }, []);
+
   const endTourStep = useCallback(
     async (stepId: SecurityStepId) => {
       await guidedOnboardingApi?.completeGuideStep('security', stepId);
-      resetStep();
+      if (isMounted) {
+        resetStep();
+      }
     },
-    [resetStep, guidedOnboardingApi]
+    [resetStep, guidedOnboardingApi, isMounted]
   );
 
   const context = {