refactor: 💡 change how uiActions are passed to vis embeddable

elastic · Mar 23, 2020 · e29030f · e29030f
1 parent af3777c
commit e29030f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/...plugins/visualizations/public/np_ready/public/embeddable/visualize_embeddable_factory.tsx b/...plugins/visualizations/public/np_ready/public/embeddable/visualize_embeddable_factory.tsx
@@ -54,7 +54,9 @@ export class VisualizeEmbeddableFactory extends EmbeddableFactory<
   public readonly type = VISUALIZE_EMBEDDABLE_TYPE;
 
   constructor(
-    private readonly getServices: () => Promise<Pick<VisualizationsStartDeps, 'uiActions'>>
+    private readonly getUiActions: () => Promise<
+      Pick<VisualizationsStartDeps, 'uiActions'>['uiActions']
+    >
   ) {
     super({
       savedObjectMetaData: {
@@ -117,7 +119,7 @@ export class VisualizeEmbeddableFactory extends EmbeddableFactory<
 
       const indexPattern = await getIndexPattern(savedObject);
       const indexPatterns = indexPattern ? [indexPattern] : [];
-      const { uiActions } = await this.getServices();
+      const uiActions = await this.getUiActions();
 
       const editable = await this.isEditable();
       return new VisualizeEmbeddable(

diff --git a/src/legacy/core_plugins/visualizations/public/np_ready/public/plugin.ts b/src/legacy/core_plugins/visualizations/public/np_ready/public/plugin.ts
@@ -115,7 +115,7 @@ export class VisualizationsPlugin
     expressions.registerRenderer(visualizationRenderer);
 
     const embeddableFactory = new VisualizeEmbeddableFactory(
-      async () => (await core.getStartServices())[1]
+      async () => (await core.getStartServices())[1].uiActions
     );
     embeddable.registerEmbeddableFactory(VISUALIZE_EMBEDDABLE_TYPE, embeddableFactory);