Update editor.test.tsx

elastic · Mar 30, 2022 · e50a0aa · e50a0aa
1 parent 74342d5
commit e50a0aa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/plugins/console/public/application/components/settings_modal.tsx b/src/plugins/console/public/application/components/settings_modal.tsx
@@ -177,7 +177,7 @@ export function DevToolsSettingsModal(props: Props) {
  <FormattedMessage
  id="console.settingsPage.refreshingDataDescription"
  defaultMessage="Console refreshes autocomplete suggestions by querying Elasticsearch.
- Less frequent refresh is recommended to reduce bandwith costs."
+ Less frequent refresh is recommended to reduce bandwidth costs."
  />
  }
  >

diff --git a/...lugins/console/public/application/containers/editor/legacy/console_editor/editor.test.tsx b/...lugins/console/public/application/containers/editor/legacy/console_editor/editor.test.tsx
@@ -41,7 +41,7 @@ describe('Legacy (Ace) Console Editor Component Smoke Test', () => {
  <ServicesContextProvider value={mockedAppContextValue}>
  <RequestContextProvider>
  <EditorContextProvider settings={{} as unknown as DevToolsSettings}>
- <Editor initialTextValue="" />
+ <Editor initialTextValue="" setEditorInstance={() => {}} />
  </EditorContextProvider>
  </RequestContextProvider>
  </ServicesContextProvider>

diff --git a/src/plugins/console/public/application/containers/editor/legacy/console_editor/editor.tsx b/src/plugins/console/public/application/containers/editor/legacy/console_editor/editor.tsx
@@ -225,16 +225,16 @@ function EditorUI({ initialTextValue, setEditorInstance }: EditorProps) {
  editor!.getCoreEditor().getContainer().focus();
  }, [settings]);
 
- const { keyboardShortcutsDisabled } = settingsService.toJSON();
  useEffect(() => {
+ const { keyboardShortcutsDisabled } = settings;
  if (!keyboardShortcutsDisabled) {
  registerCommands({
  senseEditor: editorInstanceRef.current!,
  sendCurrentRequestToES,
  openDocumentation,
  });
  }
- }, [sendCurrentRequestToES, openDocumentation, keyboardShortcutsDisabled]);
+ }, [sendCurrentRequestToES, openDocumentation, settings]);
 
  useEffect(() => {
  const { current: editor } = editorInstanceRef;