Fix some remarks

elastic · Apr 8, 2021 · e983cfd · e983cfd
1 parent e2fce06
commit e983cfd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/plugins/kibana_utils/common/errors/errors.ts b/src/plugins/kibana_utils/common/errors/errors.ts
@@ -57,7 +57,7 @@ export class SavedFieldNotFound extends KbnError {
 }
 
 /**
- * A saved field type doesn't compatible with aggregation
+ * A saved field type isn't compatible with aggregation
  */
 export class SavedFieldTypeInvalidForAgg extends KbnError {
   constructor(message: string) {

diff --git a/src/plugins/visualizations/public/embeddable/visualize_embeddable.ts b/src/plugins/visualizations/public/embeddable/visualize_embeddable.ts
@@ -151,9 +151,8 @@ export class VisualizeEmbeddable
     this.subscriptions.push(
       this.getUpdated$().subscribe((value) => {
         const isDirty = this.handleChanges();
-        // we shouldn't try to update handler if we have error
-        // because it can lead to show error twice
-        if (isDirty && this.handler && !get(value, 'error.stack')) {
+
+        if (isDirty && this.handler) {
           this.updateHandler();
         }
       })