Update filter ratio setting numerator denominator function

elastic · Jul 12, 2021 · eb187af · eb187af
1 parent 107cb2b
commit eb187af
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/test/functional/apps/visualize/_tsvb_table.ts b/test/functional/apps/visualize/_tsvb_table.ts
@@ -92,10 +92,8 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
       it('should display correct values for filter ratio aggregation with numerator and denominator', async () => {
         const EXPECTED = 'OS Filter Ratio\nwin 8 2\nwin xp 0\nwin 7 3\nios 0\nosx 0';
         await visualBuilder.selectAggType('Filter Ratio');
-        await visualBuilder.setFilterRatioNumeratorDenominator(
-          'extension.raw : "css"',
-          'bytes <= 3000'
-        );
+        await visualBuilder.setFilterRatioNumerator('extension.raw : "css"');
+        await visualBuilder.setFilterRatioDenominator('bytes <= 3000');
         await visChart.waitForVisualizationRenderingStabilized();
 
         const tableData = await visualBuilder.getViewTable();

diff --git a/test/functional/page_objects/visual_builder_page.ts b/test/functional/page_objects/visual_builder_page.ts
@@ -728,14 +728,17 @@ export class VisualBuilderPageObject extends FtrService {
     });
   }
 
-  public async setFilterRatioNumeratorDenominator(
-    numerator: string = '',
-    denominator: string = ''
-  ) {
-    const [numeratorInput, denominatorInput] = await this.find.allByCssSelector(
+  public async setFilterRatioNumerator(numerator: string) {
+    const numeratorInput = await this.find.byCssSelector(
       '.tvbAggRow [data-test-subj="queryInput"]'
     );
     await numeratorInput.type(numerator);
+  }
+
+  public async setFilterRatioDenominator(denominator: string) {
+    const [, denominatorInput] = await this.find.allByCssSelector(
+      '.tvbAggRow [data-test-subj="queryInput"]'
+    );
     await denominatorInput.type(denominator);
   }
 }