Clean up double negative on disableField

elastic · Feb 9, 2021 · f16fd97 · f16fd97
1 parent 60644ad
commit f16fd97
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/...arch/public/applications/app_search/components/relevance_tuning/relevance_tuning_logic.ts b/...arch/public/applications/app_search/components/relevance_tuning/relevance_tuning_logic.ts
@@ -377,15 +377,14 @@ export const RelevanceTuningLogic = kea<
     },
     toggleSearchField: ({ name, disableField }) => {
       const { searchSettings } = values;
-      const { search_fields: searchFields } = searchSettings;
+
+      const searchFields = disableField
+        ? omit(searchSettings.search_fields, name)
+        : { ...searchSettings.search_fields, [name]: { weight: 1 } };
 
       actions.setSearchSettings({
         ...searchSettings,
-        boosts: searchSettings.boosts,
-        search_fields: {
-          ...omit(searchFields, name),
-          ...(!disableField && { [name]: { weight: 1 } }),
-        },
+        search_fields: searchFields,
       });
     },
     updateFieldWeight: ({ name, weight }) => {
@@ -394,7 +393,6 @@ export const RelevanceTuningLogic = kea<
 
       actions.setSearchSettings({
         ...searchSettings,
-        boosts: searchSettings.boosts,
         search_fields: {
           ...searchFields,
           [name]: {