fixed type check and extended error message for invalid URL

elastic · Jun 30, 2020 · f3c998a · f3c998a
1 parent e725ed9
commit f3c998a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/x-pack/plugins/actions/server/builtin_action_types/webhook.test.ts b/x-pack/plugins/actions/server/builtin_action_types/webhook.test.ts
@@ -121,7 +121,7 @@ describe('config validation', () => {
     expect(() => {
       validateConfig(actionType, config);
     }).toThrowErrorMatchingInlineSnapshot(
-      '"error validating action type config: error configuring webhook action: unable to parse host name from Url"'
+      '"error validating action type config: error configuring webhook action: unable to parse url: TypeError: Invalid URL: example.com/do-something"'
     );
   });
 

diff --git a/x-pack/plugins/actions/server/builtin_action_types/webhook.ts b/x-pack/plugins/actions/server/builtin_action_types/webhook.ts
@@ -90,7 +90,7 @@ function validateActionTypeConfig(
     url = new URL(configObject.url);
   } catch (err) {
     return i18n.translate('xpack.actions.builtin.webhook.webhookConfigurationErrorNoHostname', {
-      defaultMessage: 'error configuring webhook action: unable to parse host name from Url',
+      defaultMessage: `error configuring webhook action: unable to parse url: ${err}`,
     });
   }
 

diff --git a/x-pack/plugins/triggers_actions_ui/public/application/lib/value_validators.ts b/x-pack/plugins/triggers_actions_ui/public/application/lib/value_validators.ts
@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { constant, isEmpty } from 'lodash';
+import { constant } from 'lodash';
 
 export function throwIfAbsent<T>(message: string) {
   return (value: T | undefined): T => {