Allow to disable system actions

elastic · Jul 22, 2023 · f479dff · f479dff
1 parent 25a93f0
commit f479dff
Show file tree

Hide file tree

Showing 3 changed files with 94 additions and 77 deletions.
diff --git a/x-pack/plugins/actions/server/action_type_registry.test.ts b/x-pack/plugins/actions/server/action_type_registry.test.ts
@@ -49,10 +49,10 @@ describe('actionTypeRegistry', () => {
  isSystemAction: false,
  },
  {
- actionTypeId: '.cases',
+ actionTypeId: 'test.system-action',
  config: {},
- id: 'system-connector-.cases',
- name: 'System action: .cases',
+ id: 'system-connector-test.system-action',
+ name: 'System action: test.system-action',
  secrets: {},
  isPreconfigured: false,
  isDeprecated: false,
@@ -393,7 +393,7 @@ describe('actionTypeRegistry', () => {
  const actionTypeRegistry = new ActionTypeRegistry(actionTypeRegistryParams);
 
  actionTypeRegistry.register({
- id: '.cases',
+ id: 'test.system-action',
  name: 'Cases',
  minimumLicenseRequired: 'platinum',
  supportedFeatureIds: ['alerting'],
@@ -410,7 +410,7 @@ describe('actionTypeRegistry', () => {
 
  expect(actionTypes).toEqual([
  {
- id: '.cases',
+ id: 'test.system-action',
  name: 'Cases',
  enabled: true,
  enabledInConfig: true,
@@ -497,13 +497,16 @@ describe('actionTypeRegistry', () => {
  expect(actionTypeRegistry.isActionExecutable('my-slack1', 'foo')).toEqual(true);
  });
 
- test('should return true when isActionTypeEnabled is false and isLicenseValidForActionType is true and it has system connectors', async () => {
+ test('should return false when isActionTypeEnabled is false and isLicenseValidForActionType is true and it has system connectors', async () => {
  mockedActionsConfig.isActionTypeEnabled.mockReturnValue(false);
  mockedLicenseState.isLicenseValidForActionType.mockReturnValue({ isValid: true });
 
  expect(
- actionTypeRegistry.isActionExecutable('system-connector-.cases', 'system-action-type')
- ).toEqual(true);
+ actionTypeRegistry.isActionExecutable(
+ 'system-connector-test.system-action',
+ 'system-action-type'
+ )
+ ).toEqual(false);
  });
 
  test('should call isLicenseValidForActionType of the license state with notifyUsage false by default', async () => {
@@ -662,7 +665,7 @@ describe('actionTypeRegistry', () => {
  const registry = new ActionTypeRegistry(actionTypeRegistryParams);
 
  registry.register({
- id: '.cases',
+ id: 'test.system-action',
  name: 'Cases',
  minimumLicenseRequired: 'platinum',
  supportedFeatureIds: ['alerting'],
@@ -675,7 +678,7 @@ describe('actionTypeRegistry', () => {
  executor,
  });
 
- const result = registry.isSystemActionType('.cases');
+ const result = registry.isSystemActionType('test.system-action');
  expect(result).toBe(true);
  });
 
@@ -720,7 +723,7 @@ describe('actionTypeRegistry', () => {
  const registry = new ActionTypeRegistry(actionTypeRegistryParams);
 
  registry.register({
- id: '.cases',
+ id: 'test.system-action',
  name: 'Cases',
  minimumLicenseRequired: 'platinum',
  supportedFeatureIds: ['alerting'],
@@ -734,15 +737,15 @@ describe('actionTypeRegistry', () => {
  executor,
  });
 
- const result = registry.getSystemActionKibanaPrivileges('.cases');
+ const result = registry.getSystemActionKibanaPrivileges('test.system-action');
  expect(result).toEqual(['test/create']);
  });
 
  it('should return an empty array if the system action does not define any kibana privileges', () => {
  const registry = new ActionTypeRegistry(actionTypeRegistryParams);
 
  registry.register({
- id: '.cases',
+ id: 'test.system-action',
  name: 'Cases',
  minimumLicenseRequired: 'platinum',
  supportedFeatureIds: ['alerting'],
@@ -755,7 +758,7 @@ describe('actionTypeRegistry', () => {
  executor,
  });
 
- const result = registry.getSystemActionKibanaPrivileges('.cases');
+ const result = registry.getSystemActionKibanaPrivileges('test.system-action');
  expect(result).toEqual([]);
  });
 
@@ -784,7 +787,7 @@ describe('actionTypeRegistry', () => {
  const getKibanaPrivileges = jest.fn().mockReturnValue(['test/create']);
 
  registry.register({
- id: '.cases',
+ id: 'test.system-action',
  name: 'Cases',
  minimumLicenseRequired: 'platinum',
  supportedFeatureIds: ['alerting'],
@@ -798,7 +801,7 @@ describe('actionTypeRegistry', () => {
  executor,
  });
 
- registry.getSystemActionKibanaPrivileges('.cases', { foo: 'bar' });
+ registry.getSystemActionKibanaPrivileges('test.system-action', { foo: 'bar' });
  expect(getKibanaPrivileges).toHaveBeenCalledWith({ params: { foo: 'bar' } });
  });
  });

diff --git a/x-pack/plugins/actions/server/action_type_registry.ts b/x-pack/plugins/actions/server/action_type_registry.ts
@@ -79,19 +79,24 @@ export class ActionTypeRegistry {
  }
 
  /**
- * Returns true if action type is enabled or it is an in memory action type.
+ * Returns true if action type is enabled or it is a preconfigured action type
+ * It is possible for to disable an action type but use a preconfigured action
+ * of action type the disabled one. This does not apply to system actions.
+ * It should be possible to disable a system action type.
  */
  public isActionExecutable(
  actionId: string,
  actionTypeId: string,
  options: { notifyUsage: boolean } = { notifyUsage: false }
  ) {
  const actionTypeEnabled = this.isActionTypeEnabled(actionTypeId, options);
+ const inMemoryConnector = this.inMemoryConnectors.find(
+ (connector) => connector.id === actionId
+ );
+
  return (
  actionTypeEnabled ||
- (!actionTypeEnabled &&
- this.inMemoryConnectors.find((inMemoryConnector) => inMemoryConnector.id === actionId) !==
- undefined)
+ (!actionTypeEnabled && inMemoryConnector !== undefined && inMemoryConnector.isPreconfigured)
  );
  }