Rename the component

elastic · Aug 17, 2023 · f7e8309 · f7e8309
1 parent 461feb9
commit f7e8309
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 13 deletions.
diff --git a/...gins/navigation_embeddable/public/components/editor/navigation_embeddable_link_editor.tsx b/...gins/navigation_embeddable/public/components/editor/navigation_embeddable_link_editor.tsx
@@ -27,10 +27,14 @@ import {
   EuiRadioGroupOption,
 } from '@elastic/eui';
 import { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container';
+import {
+  UrlDrilldownCollectConfig,
+  UrlDrilldownConfig,
+} from '@kbn/ui-actions-enhanced-plugin/public';
 import {
   withSuspense,
   DashboardDrilldownOptions,
-  LazyDashboardDrilldownOptionToggles,
+  LazyDashboardDrilldownOptionsComponent,
 } from '@kbn/presentation-util-plugin/public';
 
 import {
@@ -45,7 +49,10 @@ import { NavigationEmbeddableUnorderedLink } from '../../editor/open_link_editor
 import { ExternalLinkDestinationPicker } from '../external_link/external_link_destination_picker';
 import { DashboardLinkDestinationPicker } from '../dashboard_link/dashboard_link_destination_picker';
 
-const DashboardDrilldownOptionToggles = withSuspense(LazyDashboardDrilldownOptionToggles, null);
+const DashboardDrilldownOptionsComponent = withSuspense(
+  LazyDashboardDrilldownOptionsComponent,
+  null
+);
 
 export const NavigationEmbeddableLinkEditor = ({
   link,
@@ -70,6 +77,8 @@ export const NavigationEmbeddableLinkEditor = ({
     useCurrentFilters: true,
   });
 
+  // | UrlDrilldownConfig
+
   const linkTypes: EuiRadioGroupOption[] = useMemo(() => {
     return ([DASHBOARD_LINK_TYPE, EXTERNAL_LINK_TYPE] as NavigationLinkType[]).map((type) => {
       return {
@@ -187,12 +196,13 @@ export const NavigationEmbeddableLinkEditor = ({
 
           <EuiFormRow label={'Options'}>
             {selectedLinkType === DASHBOARD_LINK_TYPE ? (
-              <DashboardDrilldownOptionToggles
+              <DashboardDrilldownOptionsComponent
                 options={linkOptions}
                 onOptionChange={(change) => setLinkOptions({ ...linkOptions, ...change })}
               />
             ) : (
-              <>Link config</>
+              // <UrlDrilldownCollectConfig />
+              <>Config</>
             )}
           </EuiFormRow>
         </EuiForm>

diff --git a/...ns/dashboard_drilldown_option_toggles.tsx → ...n_options/dashboard_drilldown_options.tsx b/...ns/dashboard_drilldown_option_toggles.tsx → ...n_options/dashboard_drilldown_options.tsx
@@ -16,7 +16,7 @@ interface DashboardDrilldownOptionsProps {
   onOptionChange: (newOptions: Partial<DashboardDrilldownOptions>) => void;
 }
 
-const DashboardDrilldownOptionToggles = ({
+const DashboardDrilldownOptionsComponent = ({
   options,
   onOptionChange,
 }: DashboardDrilldownOptionsProps) => {
@@ -58,4 +58,4 @@ const DashboardDrilldownOptionToggles = ({
 
 // required for dynamic import using React.lazy()
 // eslint-disable-next-line import/no-default-export
-export default DashboardDrilldownOptionToggles;
+export default DashboardDrilldownOptionsComponent;
diff --git a/src/plugins/presentation_util/public/components/index.tsx b/src/plugins/presentation_util/public/components/index.tsx
@@ -42,8 +42,8 @@ export const LazyDataViewPicker = React.lazy(() => import('./data_view_picker/da
 
 export const LazyFieldPicker = React.lazy(() => import('./field_picker/field_picker'));
 
-export const LazyDashboardDrilldownOptionToggles = React.lazy(
-  () => import('./dashboard_drilldown_options/dashboard_drilldown_option_toggles')
+export const LazyDashboardDrilldownOptionsComponent = React.lazy(
+  () => import('./dashboard_drilldown_options/dashboard_drilldown_options')
 );
 
 export { FloatingActions } from './floating_actions/floating_actions';

diff --git a/src/plugins/presentation_util/public/index.ts b/src/plugins/presentation_util/public/index.ts
@@ -33,11 +33,11 @@ export {
   LazyLabsFlyout,
   LazyDashboardPicker,
   LazySavedObjectSaveModalDashboard,
-  LazyDashboardDrilldownOptionToggles,
   withSuspense,
   LazyDataViewPicker,
   LazyFieldPicker,
   FloatingActions,
+  LazyDashboardDrilldownOptionsComponent,
 } from './components';
 
 export {

diff --git a/..._dashboard_drilldown/components/dashboard_drilldown_config/dashboard_drilldown_config.tsx b/..._dashboard_drilldown/components/dashboard_drilldown_config/dashboard_drilldown_config.tsx
@@ -8,14 +8,14 @@
 import React from 'react';
 import { EuiFormRow, EuiComboBox, EuiComboBoxOptionOption } from '@elastic/eui';
 import {
-  LazyDashboardDrilldownOptionToggles,
+  LazyDashboardDrilldownOptionsComponent,
   withSuspense,
 } from '@kbn/presentation-util-plugin/public';
 
+import { DrilldownConfig } from '../../types';
 import { txtChooseDestinationDashboard } from './i18n';
-import { DrilldownConfig } from '../../../../../../common/drilldowns/dashboard_drilldown/types';
 
-const DashboardDrilldownOptionToggles = withSuspense(LazyDashboardDrilldownOptionToggles, null);
+const DashboardDrilldownOptions = withSuspense(LazyDashboardDrilldownOptionsComponent, null);
 
 export interface DashboardDrilldownConfigProps {
   error?: string;
@@ -56,7 +56,7 @@ export const DashboardDrilldownConfig: React.FC<DashboardDrilldownConfigProps> =
           }
         />
       </EuiFormRow>
-      <DashboardDrilldownOptionToggles options={config} onOptionChange={onConfigChange} />
+      <DashboardDrilldownOptions options={config} onOptionChange={onConfigChange} />
     </>
   );
 };