Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Stack Management page conversions for new layout #101336

Closed
15 of 16 tasks
cchaos opened this issue Jun 3, 2021 · 2 comments
Closed
15 of 16 tasks

[Meta] Stack Management page conversions for new layout #101336

cchaos opened this issue Jun 3, 2021 · 2 comments
Labels
Meta Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v7.14.0

Comments

@cchaos
Copy link
Contributor

cchaos commented Jun 3, 2021

This is a meta ticket in support of the greater [META] 7.14 Solution Nav implementation #98359 and is based off/dependent on #101335.

Plugins to migrate

@cchaos

Stack Management [ @cjcenizal ]

ML [ @peteharverson ]

ML meta issue #102315

  • Transforms
  • Machine Learning Jobs

Alerting services [ @YulNaumenko ]

Security [ @legrego ]

#101660

  • Users
  • Roles
  • API Keys
  • Role Mappings
  • Spaces

App services [ @Dosant ]

#101625

  • Index Patterns
  • Search sessions
  • Reporting

Kibana App

Core [ @pgayvallet ]

#101605

  • Saved Objects
  • Tags

Examples of conversions

A couple pages were converted in the setup PR to act as examples. I'm duplicating those examples here as well to help those converting.

Empty states

Empty

<EuiPageContent verticalPosition="center" horizontalPosition="center" color="subdued">
  <EuiEmptyPrompt iconType="" title={<h2></h2>} body={<p></p>} actions={[]} />
</EuiPageContent>

Example commit: bbb74b7

Error states

Error

<EuiPageContent verticalPosition="center" horizontalPosition="center" color="danger">
  <EuiEmptyPrompt iconType="" title={<h2></h2>} body={<p></p>} actions={[]} />
</EuiPageContent>

Example commit: 56cf855

If you are having trouble centering your content ensure that any blank divs around your content have the APP_WRAPPER_CLASS.

Normal page with page header

To be sure the page header renders correctly always add bottomBorder and add a l (large) size spacer between it and the content.

Page header

<EuiPageHeader
  pageTitle=""
  bottomBorder
  rightSideItems={[
    <EuiButton fill iconType="iconInCircleFilled">
      Create ___
    </EuiButton>,
  ]}
  tabs={[]}
/>

<EuiSpacer size="l" />

Example commit: ebc33a2

Panels & Split panels

Be sure that any internal EuiPanel doesn't contain a shadow. You can turn off shadows with hasShadow={false} or use borders instead with hasBorder={true}.

EuiSplitPanel is a new component that can be used in some of the unique patterns we see throughout management. Mainly the panels that have headings like in Advanced Settings.

Split panels

Example commit: bc3b85b

@cchaos
Copy link
Contributor Author

cchaos commented Jun 8, 2021

For those working on this conversion, the setup PR #101335 has been merged down to master and is currently getting backported to 7.14. Go ahead and start your PR's based on master! 🙇‍♀️

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Kibana-Design)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 29, 2021
@snide snide closed this as completed Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v7.14.0
Projects
None yet
Development

No branches or pull requests

4 participants