[ML] Transforms: Converts management pages to new layout #102648

peteharverson · 2021-06-18T14:26:50Z

Summary

Updates the Transforms management app to conform to the new layout for page panels, headers and error states, as outlined in #101336.

Part of #102315

Examples before changes:

Examples after changes:

Checklist

Unit or functional tests were updated or added to match the most common scenarios
This was checked for cross-browser compatibility

elasticmachine · 2021-06-18T14:26:53Z

Pinging @elastic/ml-ui (:ml)

cchaos · 2021-06-21T13:44:54Z

x-pack/plugins/transform/public/app/lib/authorization/components/with_privileges.tsx

+ <EuiFlexGroup justifyContent="spaceAround">
+ <EuiFlexItem grow={false}>
+ <EuiPageContent verticalPosition="center" horizontalPosition="center" color="danger">


❤️ Thanks for this PR @peteharverson !

QQ: I noticed that this error empty state is not vertically centered (in the screenshot) and my guess is that it has to do with the flex group/item wrapper. Does removing the them get it centered? Otherwise, I'd continue to look at any wrappers between the last .euiPageContentBody provided by the template, and your content.

@cchaos I fixed the vertical centering of the error empty state in 3ec6037 and updated the corresponding screenshot in the description.

qn895 · 2021-06-22T16:03:03Z

Code LGTM

cchaos

Screenshots and quick scan of code LGTM! Thanks @peteharverson

peteharverson · 2021-06-24T08:23:09Z

@elasticmachine merge upstream

kibanamachine · 2021-06-24T10:27:17Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: da5bb94
Storybooks Preview
Flaky suites:
- xpack-accessibility

Test Failures

Kibana Pipeline / general / X-Pack Accessibility Tests.x-pack/test/accessibility/apps/spaces·ts.Kibana spaces page meets a11y validations a11y test for space selection page

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/100968

[00:00:00]       │
[00:02:19]         └-: Kibana spaces page meets a11y validations
[00:02:19]           └-> "before all" hook for "a11y test for manage spaces menu from top nav on Kibana home"
[00:02:19]           └-> "before all" hook for "a11y test for manage spaces menu from top nav on Kibana home"
[00:02:19]             │ info [x-pack/test/functional/es_archives/empty_kibana] Loading "mappings.json"
[00:02:19]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] [.kibana_1/XtMzIT8jTE-JTUXbXehVGw] deleting index
[00:02:19]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] [.kibana_task_manager_8.0.0_001/DKC80E_ATUGi3ZTloVGs3Q] deleting index
[00:02:19]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] [.kibana_8.0.0_001/9VczxdJ-S-W_I-SAMpQN_A] deleting index
[00:02:19]             │ info [x-pack/test/functional/es_archives/empty_kibana] Deleted existing index ".kibana_8.0.0_001"
[00:02:19]             │ info [x-pack/test/functional/es_archives/empty_kibana] Deleted existing index ".kibana_task_manager_8.0.0_001"
[00:02:19]             │ info [x-pack/test/functional/es_archives/empty_kibana] Deleted existing index ".kibana_1"
[00:02:19]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1]
[00:02:19]             │ info [x-pack/test/functional/es_archives/empty_kibana] Created index ".kibana_1"
[00:02:19]             │ debg [x-pack/test/functional/es_archives/empty_kibana] ".kibana_1" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:02:19]             │ debg Migrating saved objects
[00:02:19]             │ proc [kibana]   log   [08:49:55.613] [info][savedobjects-service] [.kibana_task_manager] INIT -> CREATE_NEW_TARGET. took: 10ms.
[00:02:19]             │ proc [kibana]   log   [08:49:55.618] [info][savedobjects-service] [.kibana] INIT -> WAIT_FOR_YELLOW_SOURCE. took: 17ms.
[00:02:19]             │ proc [kibana]   log   [08:49:55.622] [info][savedobjects-service] [.kibana] WAIT_FOR_YELLOW_SOURCE -> SET_SOURCE_WRITE_BLOCK. took: 4ms.
[00:02:19]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] [.kibana_task_manager_8.0.0_001] creating index, cause [api], templates [], shards [1]/[1]
[00:02:19]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] updating number_of_replicas to [0] for indices [.kibana_task_manager_8.0.0_001]
[00:02:19]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] adding block write to indices [[.kibana_1/8Q7DGKBcRcCtj610pJMJMg]]
[00:02:19]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] completed adding block write to indices [.kibana_1]
[00:02:19]             │ proc [kibana]   log   [08:49:55.719] [info][savedobjects-service] [.kibana_task_manager] CREATE_NEW_TARGET -> MARK_VERSION_INDEX_READY. took: 106ms.
[00:02:19]             │ proc [kibana]   log   [08:49:55.743] [info][savedobjects-service] [.kibana] SET_SOURCE_WRITE_BLOCK -> CREATE_REINDEX_TEMP. took: 121ms.
[00:02:19]             │ proc [kibana]   log   [08:49:55.776] [info][savedobjects-service] [.kibana_task_manager] MARK_VERSION_INDEX_READY -> DONE. took: 57ms.
[00:02:19]             │ proc [kibana]   log   [08:49:55.777] [info][savedobjects-service] [.kibana_task_manager] Migration completed after 174ms
[00:02:19]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] [.kibana_8.0.0_reindex_temp] creating index, cause [api], templates [], shards [1]/[1]
[00:02:19]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] updating number_of_replicas to [0] for indices [.kibana_8.0.0_reindex_temp]
[00:02:19]             │ proc [kibana]   log   [08:49:55.849] [info][savedobjects-service] [.kibana] CREATE_REINDEX_TEMP -> REINDEX_SOURCE_TO_TEMP_OPEN_PIT. took: 106ms.
[00:02:19]             │ proc [kibana]   log   [08:49:55.855] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_OPEN_PIT -> REINDEX_SOURCE_TO_TEMP_READ. took: 6ms.
[00:02:19]             │ proc [kibana]   log   [08:49:55.862] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_CLOSE_PIT. took: 7ms.
[00:02:19]             │ proc [kibana]   log   [08:49:55.866] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_CLOSE_PIT -> SET_TEMP_WRITE_BLOCK. took: 4ms.
[00:02:19]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] adding block write to indices [[.kibana_8.0.0_reindex_temp/4-Jmk5INRyirPEolRZ_M3w]]
[00:02:19]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] completed adding block write to indices [.kibana_8.0.0_reindex_temp]
[00:02:19]             │ proc [kibana]   log   [08:49:55.925] [info][savedobjects-service] [.kibana] SET_TEMP_WRITE_BLOCK -> CLONE_TEMP_TO_TARGET. took: 59ms.
[00:02:19]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] applying create index request using existing index [.kibana_8.0.0_reindex_temp] metadata
[00:02:19]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] [.kibana_8.0.0_001] creating index, cause [clone_index], templates [], shards [1]/[1]
[00:02:19]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] updating number_of_replicas to [0] for indices [.kibana_8.0.0_001]
[00:02:19]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] [.kibana_8.0.0_001/wbjNeA0qTZqRKj6oWlI2mA] create_mapping
[00:02:19]             │ proc [kibana]   log   [08:49:56.088] [info][savedobjects-service] [.kibana] CLONE_TEMP_TO_TARGET -> REFRESH_TARGET. took: 163ms.
[00:02:19]             │ proc [kibana]   log   [08:49:56.093] [info][savedobjects-service] [.kibana] REFRESH_TARGET -> OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT. took: 5ms.
[00:02:19]             │ proc [kibana]   log   [08:49:56.098] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT -> OUTDATED_DOCUMENTS_SEARCH_READ. took: 5ms.
[00:02:19]             │ proc [kibana]   log   [08:49:56.106] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_READ -> OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT. took: 8ms.
[00:02:19]             │ proc [kibana]   log   [08:49:56.110] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT -> UPDATE_TARGET_MAPPINGS. took: 4ms.
[00:02:19]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] [.kibana_8.0.0_001/wbjNeA0qTZqRKj6oWlI2mA] update_mapping [_doc]
[00:02:19]             │ proc [kibana]   log   [08:49:56.193] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS -> UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK. took: 83ms.
[00:02:19]             │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] 8144 finished with response BulkByScrollResponse[took=5.9ms,timed_out=false,sliceId=null,updated=0,created=0,deleted=0,batches=0,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:02:19]             │ proc [kibana]   log   [08:49:56.299] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK -> MARK_VERSION_INDEX_READY. took: 106ms.
[00:02:19]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] [.kibana_8.0.0_reindex_temp/4-Jmk5INRyirPEolRZ_M3w] deleting index
[00:02:20]             │ proc [kibana]   log   [08:49:56.345] [info][savedobjects-service] [.kibana] MARK_VERSION_INDEX_READY -> DONE. took: 46ms.
[00:02:20]             │ proc [kibana]   log   [08:49:56.346] [info][savedobjects-service] [.kibana] Migration completed after 745ms
[00:02:20]             │ debg [x-pack/test/functional/es_archives/empty_kibana] Migrated Kibana index after loading Kibana data
[00:02:20]             │ debg [x-pack/test/functional/es_archives/empty_kibana] Ensured that default space exists in .kibana
[00:02:20]             │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC","visualization:visualize:legacyChartsLibrary":true}
[00:02:20]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] [.kibana_8.0.0_001/wbjNeA0qTZqRKj6oWlI2mA] update_mapping [_doc]
[00:02:22]             │ debg navigating to home url: http://localhost:61161/app/home#/
[00:02:22]             │ debg navigate to: http://localhost:61161/app/home#/
[00:02:22]             │ debg browser[INFO] http://localhost:61161/app/home?_t=1624524599001#/ 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:22]             │
[00:02:22]             │ debg browser[INFO] http://localhost:61161/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:22]             │ debg ... sleep(700) start
[00:02:23]             │ debg ... sleep(700) end
[00:02:23]             │ debg returned from get, calling refresh
[00:02:24]             │ debg browser[INFO] http://localhost:61161/app/home?_t=1624524599001#/ 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:24]             │
[00:02:24]             │ debg browser[INFO] http://localhost:61161/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:24]             │ debg currentUrl = http://localhost:61161/app/home#/
[00:02:24]             │          appUrl = http://localhost:61161/app/home#/
[00:02:24]             │ debg TestSubjects.find(kibanaChrome)
[00:02:24]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:02:25]             │ debg ... sleep(501) start
[00:02:26]             │ debg ... sleep(501) end
[00:02:26]             │ debg in navigateTo url = http://localhost:61161/app/home#/
[00:02:26]           └-> a11y test for manage spaces menu from top nav on Kibana home
[00:02:26]             └-> "before each" hook: global before each for "a11y test for manage spaces menu from top nav on Kibana home"
[00:02:26]             │ debg TestSubjects.click(space-avatar-default)
[00:02:26]             │ debg Find.clickByCssSelector('[data-test-subj="space-avatar-default"]') with timeout=10000
[00:02:26]             │ debg Find.findByCssSelector('[data-test-subj="space-avatar-default"]') with timeout=10000
[00:02:26]             │ debg Waiting up to 20000ms for Manage spaces option visible...
[00:02:26]             │ debg TestSubjects.exists(manageSpaces)
[00:02:26]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="manageSpaces"]') with timeout=2500
[00:02:26]             │ debg --- retry.tryForTime error: stale element reference: element is not attached to the page document
[00:02:26]             │        (Session info: headless chrome=91.0.4472.114)
[00:02:27]             └- ✓ pass  (1.2s) "Kibana spaces page meets a11y validations a11y test for manage spaces menu from top nav on Kibana home"
[00:02:27]           └-> a11y test for manage spaces page
[00:02:27]             └-> "before each" hook: global before each for "a11y test for manage spaces page"
[00:02:27]             │ debg TestSubjects.click(manageSpaces)
[00:02:27]             │ debg Find.clickByCssSelector('[data-test-subj="manageSpaces"]') with timeout=10000
[00:02:27]             │ debg Find.findByCssSelector('[data-test-subj="manageSpaces"]') with timeout=10000
[00:02:27]             │ debg isGlobalLoadingIndicatorVisible
[00:02:27]             │ debg TestSubjects.exists(globalLoadingIndicator)
[00:02:27]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:02:29]             │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:02:29]             │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:02:29]             │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:02:29]             │ debg TestSubjects.find(globalToastList)
[00:02:29]             │ debg Find.findByCssSelector('[data-test-subj="globalToastList"]') with timeout=10000
[00:02:39]             │ debg Waiting up to 20000ms for Manage spaces page visible...
[00:02:39]             │ debg TestSubjects.exists(createSpace)
[00:02:39]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="createSpace"]') with timeout=2500
[00:02:40]             └- ✓ pass  (12.7s) "Kibana spaces page meets a11y validations a11y test for manage spaces page"
[00:02:40]           └-> a11y test for click on create space page
[00:02:40]             └-> "before each" hook: global before each for "a11y test for click on create space page"
[00:02:40]             │ debg TestSubjects.click(createSpace)
[00:02:40]             │ debg Find.clickByCssSelector('[data-test-subj="createSpace"]') with timeout=10000
[00:02:40]             │ debg Find.findByCssSelector('[data-test-subj="createSpace"]') with timeout=10000
[00:02:40]             └- ✓ pass  (488ms) "Kibana spaces page meets a11y validations a11y test for click on create space page"
[00:02:40]           └-> a11y test for for customize space card
[00:02:40]             └-> "before each" hook: global before each for "a11y test for for customize space card"
[00:02:40]             │ debg TestSubjects.click(addSpaceName)
[00:02:40]             │ debg Find.clickByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:40]             │ debg Find.findByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:40]             │ debg TestSubjects.setValue(addSpaceName, space_a)
[00:02:40]             │ debg TestSubjects.click(addSpaceName)
[00:02:40]             │ debg Find.clickByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:40]             │ debg Find.findByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:41]             │ debg TestSubjects.click(space-avatar-space_a)
[00:02:41]             │ debg Find.clickByCssSelector('[data-test-subj="space-avatar-space_a"]') with timeout=10000
[00:02:41]             │ debg Find.findByCssSelector('[data-test-subj="space-avatar-space_a"]') with timeout=10000
[00:02:41]             └- ✓ pass  (990ms) "Kibana spaces page meets a11y validations a11y test for for customize space card"
[00:02:41]           └-> a11y test for color picker
[00:02:41]           └-> a11y test for customize and reset space URL identifier
[00:02:41]             └-> "before each" hook: global before each for "a11y test for customize and reset space URL identifier"
[00:02:41]             │ debg TestSubjects.click(CustomizeOrReset)
[00:02:41]             │ debg Find.clickByCssSelector('[data-test-subj="CustomizeOrReset"]') with timeout=10000
[00:02:41]             │ debg Find.findByCssSelector('[data-test-subj="CustomizeOrReset"]') with timeout=10000
[00:02:42]             │ debg TestSubjects.click(CustomizeOrReset)
[00:02:42]             │ debg Find.clickByCssSelector('[data-test-subj="CustomizeOrReset"]') with timeout=10000
[00:02:42]             │ debg Find.findByCssSelector('[data-test-subj="CustomizeOrReset"]') with timeout=10000
[00:02:42]             └- ✓ pass  (964ms) "Kibana spaces page meets a11y validations a11y test for customize and reset space URL identifier"
[00:02:42]           └-> a11y test for describe space text space
[00:02:42]             └-> "before each" hook: global before each for "a11y test for describe space text space"
[00:02:42]             │ debg TestSubjects.click(descriptionSpaceText)
[00:02:42]             │ debg Find.clickByCssSelector('[data-test-subj="descriptionSpaceText"]') with timeout=10000
[00:02:42]             │ debg Find.findByCssSelector('[data-test-subj="descriptionSpaceText"]') with timeout=10000
[00:02:43]             └- ✓ pass  (463ms) "Kibana spaces page meets a11y validations a11y test for describe space text space"
[00:02:43]           └-> a11y test for toggling an entire feature category
[00:02:43]             └-> "before each" hook: global before each for "a11y test for toggling an entire feature category"
[00:02:43]             │ debg TestSubjects.click(featureCategoryButton_kibana)
[00:02:43]             │ debg Find.clickByCssSelector('[data-test-subj="featureCategoryButton_kibana"]') with timeout=10000
[00:02:43]             │ debg Find.findByCssSelector('[data-test-subj="featureCategoryButton_kibana"]') with timeout=10000
[00:02:43]             │ debg Find.findByCssSelector('button[aria-controls=featureCategory_kibana]') with timeout=10000
[00:02:44]             │ debg TestSubjects.click(featureCategoryButton_kibana)
[00:02:44]             │ debg Find.clickByCssSelector('[data-test-subj="featureCategoryButton_kibana"]') with timeout=10000
[00:02:44]             │ debg Find.findByCssSelector('[data-test-subj="featureCategoryButton_kibana"]') with timeout=10000
[00:02:44]             └- ✓ pass  (952ms) "Kibana spaces page meets a11y validations a11y test for toggling an entire feature category"
[00:02:44]           └-> a11y test for space listing page
[00:02:44]             └-> "before each" hook: global before each for "a11y test for space listing page"
[00:02:44]             │ debg TestSubjects.click(save-space-button)
[00:02:44]             │ debg Find.clickByCssSelector('[data-test-subj="save-space-button"]') with timeout=10000
[00:02:44]             │ debg Find.findByCssSelector('[data-test-subj="save-space-button"]') with timeout=10000
[00:02:44]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624523084564774620] [.kibana_8.0.0_001/wbjNeA0qTZqRKj6oWlI2mA] update_mapping [_doc]
[00:02:44]             └- ✓ pass  (510ms) "Kibana spaces page meets a11y validations a11y test for space listing page"
[00:02:44]           └-> a11y test for updating a space
[00:02:44]             └-> "before each" hook: global before each for "a11y test for updating a space"
[00:02:44]             │ debg TestSubjects.click(space_a-editSpace)
[00:02:44]             │ debg Find.clickByCssSelector('[data-test-subj="space_a-editSpace"]') with timeout=10000
[00:02:44]             │ debg Find.findByCssSelector('[data-test-subj="space_a-editSpace"]') with timeout=10000
[00:02:45]             │ debg TestSubjects.click(cancel-space-button)
[00:02:45]             │ debg Find.clickByCssSelector('[data-test-subj="cancel-space-button"]') with timeout=10000
[00:02:45]             │ debg Find.findByCssSelector('[data-test-subj="cancel-space-button"]') with timeout=10000
[00:02:45]             └- ✓ pass  (721ms) "Kibana spaces page meets a11y validations a11y test for updating a space"
[00:02:45]           └-> a11y test for delete space button
[00:02:45]             └-> "before each" hook: global before each for "a11y test for delete space button"
[00:02:45]             │ debg TestSubjects.click(createSpace)
[00:02:45]             │ debg Find.clickByCssSelector('[data-test-subj="createSpace"]') with timeout=10000
[00:02:45]             │ debg Find.findByCssSelector('[data-test-subj="createSpace"]') with timeout=10000
[00:02:45]             │ debg TestSubjects.click(addSpaceName)
[00:02:45]             │ debg Find.clickByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:45]             │ debg Find.findByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:45]             │ debg TestSubjects.setValue(addSpaceName, space_b)
[00:02:45]             │ debg TestSubjects.click(addSpaceName)
[00:02:45]             │ debg Find.clickByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:45]             │ debg Find.findByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:45]             │ debg TestSubjects.click(save-space-button)
[00:02:45]             │ debg Find.clickByCssSelector('[data-test-subj="save-space-button"]') with timeout=10000
[00:02:45]             │ debg Find.findByCssSelector('[data-test-subj="save-space-button"]') with timeout=10000
[00:02:45]             │ debg navigating to home url: http://localhost:61161/app/home#/
[00:02:45]             │ debg navigate to: http://localhost:61161/app/home#/
[00:02:45]             │ debg browser[INFO] http://localhost:61161/app/home?_t=1624524622141#/ 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:45]             │
[00:02:45]             │ debg browser[INFO] http://localhost:61161/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:46]             │ debg ... sleep(700) start
[00:02:46]             │ debg ... sleep(700) end
[00:02:46]             │ debg returned from get, calling refresh
[00:02:47]             │ debg browser[INFO] http://localhost:61161/app/home?_t=1624524622141#/ 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:47]             │
[00:02:47]             │ debg browser[INFO] http://localhost:61161/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:47]             │ debg currentUrl = http://localhost:61161/app/home#/
[00:02:47]             │          appUrl = http://localhost:61161/app/home#/
[00:02:47]             │ debg TestSubjects.find(kibanaChrome)
[00:02:47]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:02:48]             │ debg ... sleep(501) start
[00:02:48]             │ debg ... sleep(501) end
[00:02:48]             │ debg in navigateTo url = http://localhost:61161/app/home#/
[00:02:48]             │ debg openSpacesNav()
[00:02:48]             │ debg TestSubjects.click(spacesNavSelector)
[00:02:48]             │ debg Find.clickByCssSelector('[data-test-subj="spacesNavSelector"]') with timeout=10000
[00:02:48]             │ debg Find.findByCssSelector('[data-test-subj="spacesNavSelector"]') with timeout=10000
[00:02:49]             │ info SpaceSelectorPage:clickSpaceAvatar(space_b)
[00:02:49]             │ debg TestSubjects.click(space-avatar-space_b)
[00:02:49]             │ debg Find.clickByCssSelector('[data-test-subj="space-avatar-space_b"]') with timeout=10000
[00:02:49]             │ debg Find.findByCssSelector('[data-test-subj="space-avatar-space_b"]') with timeout=10000
[00:02:49]             │ debg ... sleep(1000) start
[00:02:49]             │ debg browser[INFO] http://localhost:61161/s/space_b/app/home 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:49]             │
[00:02:49]             │ debg browser[INFO] http://localhost:61161/s/space_b/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:50]             │ debg ... sleep(1000) end
[00:02:50]             │ debg isGlobalLoadingIndicatorVisible
[00:02:50]             │ debg TestSubjects.exists(globalLoadingIndicator)
[00:02:50]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:02:52]             │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:02:53]             │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:02:53]             │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:02:53]             │ debg openSpacesNav()
[00:02:53]             │ debg TestSubjects.click(spacesNavSelector)
[00:02:53]             │ debg Find.clickByCssSelector('[data-test-subj="spacesNavSelector"]') with timeout=10000
[00:02:53]             │ debg Find.findByCssSelector('[data-test-subj="spacesNavSelector"]') with timeout=10000
[00:02:53]             │ debg TestSubjects.click(manageSpaces)
[00:02:53]             │ debg Find.clickByCssSelector('[data-test-subj="manageSpaces"]') with timeout=10000
[00:02:53]             │ debg Find.findByCssSelector('[data-test-subj="manageSpaces"]') with timeout=10000
[00:02:53]             │ debg TestSubjects.click(space_b-deleteSpace)
[00:02:53]             │ debg Find.clickByCssSelector('[data-test-subj="space_b-deleteSpace"]') with timeout=10000
[00:02:53]             │ debg Find.findByCssSelector('[data-test-subj="space_b-deleteSpace"]') with timeout=10000
[00:02:54]             └- ✓ pass  (9.3s) "Kibana spaces page meets a11y validations a11y test for delete space button"
[00:02:54]           └-> a11y test for space selection page
[00:02:54]             └-> "before each" hook: global before each for "a11y test for space selection page"
[00:02:54]             │ debg TestSubjects.click(confirmModalConfirmButton)
[00:02:54]             │ debg Find.clickByCssSelector('[data-test-subj="confirmModalConfirmButton"]') with timeout=10000
[00:02:54]             │ debg Find.findByCssSelector('[data-test-subj="confirmModalConfirmButton"]') with timeout=10000
[00:02:54]             │ info Taking screenshot "/dev/shm/workspace/parallel/16/kibana/x-pack/test/functional/screenshots/failure/Kibana spaces page meets a11y validations a11y test for space selection page.png"
[00:02:54]             │ debg browser[INFO] http://localhost:61161/spaces/space_selector 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:54]             │
[00:02:54]             │ debg browser[INFO] http://localhost:61161/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:55]             │ info Current URL is: http://localhost:61161/spaces/space_selector
[00:02:55]             │ info Saving page source to: /dev/shm/workspace/parallel/16/kibana/x-pack/test/functional/failure_debug/html/Kibana spaces page meets a11y validations a11y test for space selection page.html
[00:02:55]             └- ✖ fail: Kibana spaces page meets a11y validations a11y test for space selection page
[00:02:55]             │      JavascriptError: javascript error: document unloaded while waiting for result
[00:02:55]             │   (Session info: headless chrome=91.0.4472.114)
[00:02:55]             │       at Object.throwDecodedError (/dev/shm/workspace/parallel/16/kibana/node_modules/selenium-webdriver/lib/error.js:550:15)
[00:02:55]             │       at parseHttpResponse (/dev/shm/workspace/parallel/16/kibana/node_modules/selenium-webdriver/lib/http.js:565:13)
[00:02:55]             │       at Executor.execute (/dev/shm/workspace/parallel/16/kibana/node_modules/selenium-webdriver/lib/http.js:491:26)
[00:02:55]             │       at runMicrotasks (<anonymous>)
[00:02:55]             │       at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:02:55]             │       at Task.exec (/dev/shm/workspace/parallel/16/kibana/test/functional/services/remote/prevent_parallel_calls.ts:28:20)
[00:02:55]             │ 
[00:02:55]             │

Stack Trace

JavascriptError: javascript error: document unloaded while waiting for result
  (Session info: headless chrome=91.0.4472.114)
    at Object.throwDecodedError (/dev/shm/workspace/parallel/16/kibana/node_modules/selenium-webdriver/lib/error.js:550:15)
    at parseHttpResponse (/dev/shm/workspace/parallel/16/kibana/node_modules/selenium-webdriver/lib/http.js:565:13)
    at Executor.execute (/dev/shm/workspace/parallel/16/kibana/node_modules/selenium-webdriver/lib/http.js:491:26)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Task.exec (/dev/shm/workspace/parallel/16/kibana/test/functional/services/remote/prevent_parallel_calls.ts:28:20) {
  remoteStacktrace: '#0 0x55b41aa25949 <unknown>\n'
}

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`transform`	927.9KB	928.4KB	+530.0B

History

💔 Build #133553 failed 3ec6037
💚 Build #132421 succeeded 362f8e6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

) * [ML] Transforms: Converts management pages to new layout * [ML] Fix vertical centering of error state in app Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-06-24T10:33:53Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…103236) * [ML] Transforms: Converts management pages to new layout * [ML] Fix vertical centering of error state in app Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Pete Harverson <peteharverson@users.noreply.github.com>

[ML] Transforms: Converts management pages to new layout

362f8e6

peteharverson added review :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms ML transforms v7.14.0 labels Jun 18, 2021

peteharverson requested review from cchaos, jgowdyelastic and qn895 June 18, 2021 14:26

peteharverson requested a review from a team as a code owner June 18, 2021 14:26

peteharverson mentioned this pull request Jun 18, 2021

[ML] Convert ML Jobs and Transforms Management pages to the new layout #102315

Closed

2 tasks

cchaos reviewed Jun 21, 2021

View reviewed changes

qn895 approved these changes Jun 22, 2021

View reviewed changes

[ML] Fix vertical centering of error state in app

3ec6037

cchaos approved these changes Jun 23, 2021

View reviewed changes

Merge branch 'master' into transforms-page-layout

da5bb94

peteharverson added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 24, 2021

peteharverson merged commit fa71c6d into elastic:master Jun 24, 2021

peteharverson deleted the transforms-page-layout branch June 24, 2021 10:31

kibanamachine mentioned this pull request Jun 24, 2021

[7.x] [ML] Transforms: Converts management pages to new layout (#102648) #103236

Merged

peteharverson mentioned this pull request Jun 30, 2021

[ML] Transforms: Layout issues with Transforms wizard #103882

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Transforms: Converts management pages to new layout #102648

[ML] Transforms: Converts management pages to new layout #102648

peteharverson commented Jun 18, 2021 •

edited

Loading

elasticmachine commented Jun 18, 2021

cchaos Jun 21, 2021

peteharverson Jun 23, 2021

qn895 commented Jun 22, 2021

cchaos left a comment

peteharverson commented Jun 24, 2021

kibanamachine commented Jun 24, 2021

Standard Out

Stack Trace

kibanamachine commented Jun 24, 2021

[ML] Transforms: Converts management pages to new layout #102648

[ML] Transforms: Converts management pages to new layout #102648

Conversation

peteharverson commented Jun 18, 2021 • edited Loading

Summary

Examples before changes:

Examples after changes:

Checklist

elasticmachine commented Jun 18, 2021

cchaos Jun 21, 2021

Choose a reason for hiding this comment

peteharverson Jun 23, 2021

Choose a reason for hiding this comment

qn895 commented Jun 22, 2021

cchaos left a comment

Choose a reason for hiding this comment

peteharverson commented Jun 24, 2021

kibanamachine commented Jun 24, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Async chunks

History

kibanamachine commented Jun 24, 2021

💚 Backport successful

peteharverson commented Jun 18, 2021 •

edited

Loading