Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] useParams not working in alert flyout components (service is always "All") #101837

Closed
smith opened this issue Jun 9, 2021 · 1 comment · Fixed by #104103
Closed

[APM] useParams not working in alert flyout components (service is always "All") #101837

smith opened this issue Jun 9, 2021 · 1 comment · Fixed by #104103
Assignees
@dgieselaar
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.14.0

Comments

@smith
Copy link
Contributor

smith commented Jun 9, 2021 •
edited by sorenlouv
Loading

image

In #101044, The HeaderMenuPortal was moved to be outside of routes, making it so useParams always returns an empty object.

We should be able use useRouteMatch instead, which doesn't depend on being a child of a Route.

At a minimum, use this in the alert flyout components. We could probably use it everywhere else, and maybe make a useServiceName that all the components that currently use useParams can use.
@smith smith added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.14.0 labels Jun 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv changed the title [APM] useParams not working in alert flyout components. [APM] useParams not working in alert flyout components (environment is always "All") Jun 17, 2021
@dgieselaar dgieselaar changed the title [APM] useParams not working in alert flyout components (environment is always "All") [APM] useParams not working in alert flyout components (service is always "All") Jun 29, 2021
dgieselaar added a commit to dgieselaar/kibana that referenced this issue Jul 1, 2021
@dgieselaar
[APM] Get service name from context for alert flyout
fdbf043 
Closes elastic#101837.
@dgieselaar dgieselaar mentioned this issue Jul 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgieselaar dgieselaar

Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Get service name from context for alert flyout dgieselaar/kibana
5 participants
@smith @graphaelli @sorenlouv @dgieselaar @elasticmachine