Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Waffle visualization type #107059

Closed
Tracked by #57707
ghudgins opened this issue Jul 28, 2021 · 5 comments · Fixed by #119339
Closed
Tracked by #57707

[Lens] Waffle visualization type #107059

ghudgins opened this issue Jul 28, 2021 · 5 comments · Fixed by #119339
Assignees
@alexwizp
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@ghudgins
Copy link
Contributor

ghudgins commented Jul 28, 2021 •
edited
Loading

Describe the feature:
Descriptions copied/tweaked from @monfera (more detail in this PR) elastic/elastic-charts#1255
Add waffle chart as a Visualization Type to the set of partition visualizations in Lens (alongside Pie, Treemap, Moasaic). It shows a parts to whole relationship, like pie charts or treemaps, but sometimes a better option than these. It is distinct from the gridded charts in APM that show specific units and were titled waffle map.

Describe a specific use case for the feature:
When I am showing single layer part-to-whole data on a dashboard (rectangular panels)
And My data has low cardinality and doesn't have categories with small values (small categories run the risk of not showing up)
I need a waffle visualization (instead of pie or treemap)
So I can best take advantage of the rectangular space with high degree of readability
And visualize partition data in this responsive way that doesn't collapse (like pie does)
And visualize changing data with consistent visualization results (treemaps can shuffle the results and look significantly different period to period)
@ghudgins ghudgins added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jul 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@ghudgins ghudgins mentioned this issue Jul 28, 2021
Closed
@ghudgins ghudgins mentioned this issue Sep 13, 2021
Closed
@ghudgins
Copy link
Contributor Author

A few details after talking to @elastic/datavis today

  • waffle only has 1 group by.
  • It's preferable to use waffle over pie from the datavis team's perspective...but there are issues when the slice size isn't very big. We could consider putting this above pie/donut 🤔 I'll be adding the "smarts" to detect size size ( 😉 ) to the suggestions meta.

as an aside - we probably need a separate vis type to build the equivalent of the "Inventory" visualization from Observability

@ghudgins ghudgins mentioned this issue Oct 20, 2021
Closed
11 tasks
@ghudgins
Copy link
Contributor Author

should consider a warning case if data is <1% as it will not display

@alexwizp alexwizp self-assigned this Oct 27, 2021
@MichaelMarcialis
Copy link
Contributor

MichaelMarcialis commented Oct 29, 2021 •
edited
Loading

In preparation for this feature, I've created a new icon for the waffle visualization type to be used in the Lens app. I’ve also updated the previous heatmap icon in order to better visually distinguish it from this new waffle icon. Download links are below.

@ghudgins
Copy link
Contributor Author

@alexwizp I confirmed with @markov00 that we do need to put "Experimental" on this as kibana will be the first consumer of this functionality CC @flash1293

@alexwizp alexwizp mentioned this issue Nov 22, 2021
Merged
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 23, 2021
@alexwizp
[WIP][Lens] Waffle visualization type
a5c67a7 
Closes:  elastic#107059
alexwizp added a commit that referenced this issue Dec 2, 2021
@alexwizp @kibanamachine
[Lens] Waffle visualization type (#119339)
3cd176f 
* [WIP][Lens] Waffle visualization type

Closes:  #107059

* add showExtraLegend for waffle

* add tests

* resolved 1 and 5

* resolved 6

* add sortPredicate for waffle chart type

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
DianaDerevyankina added a commit that referenced this issue Dec 20, 2021
@DianaDerevyankina @alexwizp @kibanamachine
[Lens] Pie and donuts should have a size ratio setting (#120101)
2d2d702 
* [WIP][Lens] Waffle visualization type

Closes:  #107059

* add showExtraLegend for waffle

* add tests

* resolved 1 and 5

* resolved 6

* add sortPredicate for waffle chart type

* [Lens] Pie and donuts should have a size ratio setting

* Add a missed condition

* Fix changing size for smallSlices

* Add donut inner area size setting to pie visualization and update it for lens

* Update test and rename some constants

* Rename the setting

* Move handler to a separate useCallback function

* Update size ratios and add condition for legacy charts

* Fix merge conflict issue

* Change constants order

* Add a couple of tests to check if the setting is displayed

* Update ratio sizes

Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
TinLe pushed a commit to TinLe/kibana that referenced this issue Dec 22, 2021
@alexwizp @kibanamachine @TinLe
[Lens] Waffle visualization type (elastic#119339)
eac5cfc 
* [WIP][Lens] Waffle visualization type

Closes:  elastic#107059

* add showExtraLegend for waffle

* add tests

* resolved 1 and 5

* resolved 6

* add sortPredicate for waffle chart type

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
mibragimov pushed a commit to mibragimov/kibana that referenced this issue Dec 22, 2021
@DianaDerevyankina @alexwizp @kibanamachine
[Lens] Pie and donuts should have a size ratio setting (elastic#120101)
4423695 
* [WIP][Lens] Waffle visualization type

Closes:  elastic#107059

* add showExtraLegend for waffle

* add tests

* resolved 1 and 5

* resolved 6

* add sortPredicate for waffle chart type

* [Lens] Pie and donuts should have a size ratio setting

* Add a missed condition

* Fix changing size for smallSlices

* Add donut inner area size setting to pie visualization and update it for lens

* Update test and rename some constants

* Rename the setting

* Move handler to a separate useCallback function

* Update size ratios and add condition for legacy charts

* Fix merge conflict issue

* Change constants order

* Add a couple of tests to check if the setting is displayed

* Update ratio sizes

Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] Waffle visualization type alexwizp/kibana
4 participants
@MichaelMarcialis @ghudgins @elasticmachine @alexwizp