[Actions] [7.x] Convert all savedObjectClient.get() calls to use savedObjectClient.resolve and handle the response appropriately

[chrisronline]

(No longer) Blocked

#106897 needs to be merged before this work can be finished. - has been merged!

Summary

In #100067, we need to ensure that all rule and connector saved objects are shareable. Part of this effort involves needing to regenerate saved object IDs to guarantee uniqueness across all spaces (which is currently not guaranteed). This affects existing saved objects, as every saved object will receive a new ID as part of this effort and the new .resolve() saved objects API is designed to give insight into that process for a specific saved object.

This new API not only returns the saved object (it will attempt to find the actual saved object even if the consumer provides the outdated ID) but also information on the new and old saved object IDs and based on the response, plugin owners are expected to provide a quality UX and let the user know of any actions they need to take (such as updating bookmarks, etc). (#95958 is a good reference PR for the expected type of change)

As a result of the above, various plugin's server code needs to convert to using this new saved object .resolve API. We also need to ensure the UI handles showing the user an appropriate message regarding this situation. Luckily, the core/security team built out shareable React components to do that and a good example of how is here

For the sake of consistency, I recommend all .get() calls change to .resolve() (instead of attempting to only find the places where we need to change to .resolve()). It's unclear when/if the .resolve() API deprecates, but if/when that happens, we can change all .resolve() back to .get() in one move.

List of affected areas of code

As a result of the above, the actions plugin's server code needs to convert to using this new saved object .resolve API. Our PoC PR revealed a few places where we need to do this:

• https://github.com/elastic/kibana/blob/master/x-pack/plugins/actions/server/actions_client.ts#L215
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/actions/server/actions_client.ts#L299
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/actions/server/authorization/get_authorization_mode_by_source.ts#L26
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/actions/server/create_execute_function.ts#L157

There may be more places, and changes to the above listed files might mean additional changes to callers of the above code paths.

When and backporting

This work needs to be done before 8.0. Most of the work can be backported as well. Because #107083 will handle changing the namespaceType, this PR will just need to ensure the .resolve() changes do not break existing behavior.

[elasticmachine]

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

[ymao1]

Currently, we store transient action_task_params in the Kibana index. These documents reference the associated connector SO ID in its actionId field, as well as the related alert SO ID in its relatedSavedObjects array. Since neither of these are in the SO references array, the SO IDs will become outdated if Kibana is upgraded before a queued action is run by task manager.

We could update these documents in order to use the references array but since they are temporary documents, it seems like it would be ok to just use .resolve to resolve the outdated connector SO ID:

• Rule runs and schedules an action with action_task_params with actionId: abc and relatedSavedObject alert ID of xyz
• Kibana gets upgraded and action and alert SO IDs are regenerated
• Action runs, resolves action:abc to action:def, resolves alert:xyz to alert:123, action_task_params gets deleted
  Rule runs again and schedules an action with action_task_params with actionId: def and relatedSavedObject alert ID of 123

[chrisronline]

I'm going to close this out, as the original research is invalid and need to be reworked. If this item is still applicable, we still reopen this ticket.