Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Supporting share-capable saved objects for rules and connectors #106630

Closed
wants to merge 7 commits into from
Closed

[WIP] Supporting share-capable saved objects for rules and connectors #106630

wants to merge 7 commits into from

Conversation

chrisronline
Copy link
Contributor

No description provided.

@chrisronline chrisronline mentioned this pull request Jul 26, 2021
Closed
jportner and others added 4 commits July 26, 2021 23:28
@jportner
Extract data.json.gz
4849795
@jportner
Fix tests
6bbfa82 
* The existing test data archive did not decrypt properly without the
  migration additions; it appears that was not encrypted with the same
  key that is used by the functional test server. I replaced that test
  data with fresh data that does decrypt properly.
* I added empty ESO migration functions for the alert and action saved
  object types so they will be decrypted and re-encrypted during the
  index migration process.
Note that the alias match test will not pass until the associated ESO
service bugfix is applied.
@jportner @chrisronline
Fix ESO migration decryption for converted saved object types
15e71aa 
A bug in the algorithm neglected to differentiate when a converted
object may have had its ID changed (this happens when an object exists
in a non-default space and then it is converted).
This commit fixes the bug and adds several more unit tests and
integration tests to exercise different permutations of migrations.
@chrisronline
Add more resolve in the task manager
677abd6
This was referenced Jul 28, 2021
Closed
Closed
Closed
Closed
@ymao1 ymao1 mentioned this pull request Jul 29, 2021
Closed
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 30, 2021 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/alerting/server/task_runner.Task Runner successfully executes the task

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: Cannot read property 'saved_object' of undefined
    at TaskRunner.run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/alerting/server/task_runner/task_runner.ts:544:9)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/alerting/server/task_runner/task_runner.test.ts:211:26)
Kibana Pipeline / jest / Jest Tests.x-pack/plugins/alerting/server/task_runner.Task Runner actionsPlugin.execute is called per alert instance that is scheduled

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: Cannot read property 'saved_object' of undefined
    at TaskRunner.run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/alerting/server/task_runner/task_runner.ts:544:9)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/alerting/server/task_runner/task_runner.test.ts:385:7)
Kibana Pipeline / jest / Jest Tests.x-pack/plugins/alerting/server/task_runner.Task Runner actionsPlugin.execute is called per alert instance that is scheduled (with ephemeral support)

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: Cannot read property 'saved_object' of undefined
    at TaskRunner.run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/alerting/server/task_runner/task_runner.ts:544:9)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/alerting/server/task_runner/task_runner.test.ts:385:7)

and 147 more failures, only showing the first 3.

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

This was referenced Aug 2, 2021
Closed
Closed
@chrisronline chrisronline deleted the alerting/sharecapable branch September 21, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisronline @kibanamachine @jportner