Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event log] Update findEventsBySavedObjectIds to resolve SO ids #107423

Closed
chrisronline opened this issue Aug 2, 2021 · 2 comments
Closed

[Event log] Update findEventsBySavedObjectIds to resolve SO ids #107423

chrisronline opened this issue Aug 2, 2021 · 2 comments
Labels
Feature:EventLog loe:small Small Level of Effort Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@chrisronline
Copy link
Contributor

chrisronline commented Aug 2, 2021

As part of the research done in #100666, we need to update the findEventsBySavedObjectIds client API method to properly resolve saved object ids. This API already makes use of the current space so it should be relatively easy to change.

One slight complication here is using the appropriate space for saved object id resolution, as the caller's space might differ from the namespace defined in the event log itself.

I don't expect this part of the code to need to worry about how to handle possible responses from the .resolve() API, but rather just use it to ensure we fetch the correct saved object.

For reference, here is a PoC commit (part of the overall PoC) of how we might do this.

@chrisronline chrisronline added loe:small Small Level of Effort Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:EventLog labels Aug 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@chrisronline
Copy link
Contributor Author

I'm going to close this out, as the original research is invalid and need to be reworked. If this item is still applicable, we still reopen this ticket.

@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:EventLog loe:small Small Level of Effort Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

No branches or pull requests

3 participants