[Draft] Followup issues for alerting saved object sharing

[chrisronline]

In #100067, we need to ensure that all rule and connector saved objects are shareable. Part of this effort involves needing to regenerate saved object IDs to guarantee uniqueness across all spaces (which is currently not guaranteed). This affects existing saved objects, as every saved object will receive a new ID as part of this effort and the new .resolve() saved objects API is designed to give insight into that process for a specific saved object.

This new API not only returns the saved object (it will attempt to find the actual saved object even if the consumer provides the outdated ID) but also information on the new and old saved object IDs and based on the response, plugin owners are expected to provide a quality UX and let the user know of any actions they need to take (such as updating bookmarks, etc). (#95958 is a good reference PR for the expected type of change)\

For the sake of consistency, I recommend all .get() calls change to .resolve() (instead of attempting to only find the places where we need to change to .resolve()). It's unclear when/if the .resolve() API deprecates, but if/when that happens, we can change all .resolve() back to .get() in one move.

As a result of the above, various plugin's server code needs to convert to using this new saved object .resolve API. We also need to ensure the UI handles showing the user an appropriate message regarding this situation. Luckily, the core/security team built out shareable React components to do that and a good example of how is here

We should also be able to add functional and unit tests for the above changes. For functional tests, we will need to use the es archiver tool to create saved objects from a different environment (without the changes to make our saved objects shareable, I'd recommend just going with the current minor) and use those for the tests. Here is an example

[chrisronline]

[Actions] Convert all savedObjectClient.get() calls to use savedObjectClient.resolve and handle the response appropriately

See #106787 (comment)

As a result of the above, the actions plugin's server code needs to convert to using this new saved object .resolve API. Our PoC PR revealed a few places where we need to do this:

• https://github.com/elastic/kibana/blob/master/x-pack/plugins/actions/server/actions_client.ts#L215
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/actions/server/actions_client.ts#L299
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/actions/server/authorization/get_authorization_mode_by_source.ts#L26
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/actions/server/create_execute_function.ts#L157

There may be more places, and changes to the above listed files might mean additional changes to callers of the above code paths.

[chrisronline]

[Alerting] Convert all savedObjectClient.get() calls to use savedObjectClient.resolve and handle the response appropriately

See #106787 (comment)

As a result of the above, the alerting plugin's server code needs to convert to using this new saved object .resolve API. Our PoC PR revealed a few places where we need to do this:

• https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/invalidate_pending_api_keys/task.ts#L200
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/rules_client/rules_client.ts#L382
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/rules_client/rules_client.ts#L615
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/rules_client/rules_client.ts#L694
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/rules_client/rules_client.ts#L705
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/rules_client/rules_client.ts#L873
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/rules_client/rules_client.ts#L992
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/rules_client/rules_client.ts#L1096
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/rules_client/rules_client.ts#L1110
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/rules_client/rules_client.ts#L1183
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/rules_client/rules_client.ts#L1245
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/rules_client/rules_client.ts#L1307
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/rules_client/rules_client.ts#L1375
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/task_runner/task_runner.ts#L120

We also need to handle the situation where a stored task contains a reference to an outdated saved object id, specifically the alert id, such as:

• https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/task_runner/task_runner.ts#L244
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/task_runner/task_runner.ts#L430
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/task_runner/task_runner.ts#L457
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/task_runner/task_runner.ts#L495

There may be more places, and changes to the above listed files might mean additional changes to callers of the above code paths.

[chrisronline]

[Cases] Convert all savedObjectClient.get() calls to use savedObjectClient.resolve and handle the response appropriately

See #106787 (comment)

As a result of the above, the cases plugin's server code needs to convert to using this new saved object .resolve API. Our PoC PR revealed a few places where we need to do this:

• https://github.com/elastic/kibana/blob/master/x-pack/plugins/cases/server/services/attachments/index.ts#L99
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/cases/server/services/cases/index.ts#L719
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/cases/server/services/cases/index.ts#L731
• https://github.com/elastic/kibana/blob/master/x-pack/plugins/cases/server/services/configure/index.ts#L50

There may be more places, and changes to the above listed files might mean additional changes to callers of the above code paths.

[chrisronline]

[ESO] Convert all savedObjectClient.get() calls to use savedObjectClient.resolve and handle the response appropriately

See #106787 (comment)

As a result of the above, the cases plugin's server code needs to convert to using this new saved object .resolve API. Our PoC PR revealed a few places where we need to do this:

• https://github.com/elastic/kibana/blob/master/x-pack/plugins/encrypted_saved_objects/server/saved_objects/index.ts#L86

There may be more places, and changes to the above listed files might mean additional changes to callers of the above code paths.