Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC] Bulk action popover text for workflow status change inconsistent #108912

Closed
mdefazio opened this issue Aug 17, 2021 · 7 comments
Closed

[RAC] Bulk action popover text for workflow status change inconsistent #108912

mdefazio opened this issue Aug 17, 2021 · 7 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience fixed QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team Theme: rac label obsolete v7.15.0

Comments

@mdefazio
Copy link
Contributor

mdefazio commented Aug 17, 2021

  • Bulk action popover text should read consistent for Workflow actions
  • Padding and alignment differs between bulk popover and row popver

image

@paulewing Confirming the below mockup is still accurate?

image

Should also be reflected in the row overflow actions:
image

@mdefazio mdefazio added bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Aug 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema added the Team:Threat Hunting Security Solution Threat Hunting Team label Aug 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@semd
Copy link
Contributor

semd commented Aug 19, 2021

Hi @mdefazio
I opened this pr to fix this. I opted to remove all the paddings since is what it seems in the mockup, but I would like a confirmation.

Another question: do you want me to change the menu panels and have only one level of items in all action menus (including flyout take action), or only in the table row action menus?
Thanks!

@mdefazio
Copy link
Contributor Author

@semd Yes, the padding should be removed around the popover...

image

And yes, only one level of times in all actions (including flyout take action menu). We understand there are some pitfalls with this approach (longer list), but removing the click is preferred at the moment.

cc/ @monina-n ... just fyi for the flyout work

@monina-n
Copy link

I want to point out we should be using sentence case for all actions. So for the workflow status, it should be:

  • Mark as closed
  • Mark as acknowledged

For "Investigate in Timeline", I believe it's okay to leave Timeline capitalized since that is the name of the feature

@MadameSheema
Copy link
Member

@karanbirsingh-qasource can you please validate the fix of this issue on 7.15BC2? Thanks :)

@ghost
Copy link

ghost commented Aug 25, 2021

HI @MadameSheema

we have validated this issue on 7.15.0 BC2 and found it Fixed ✔️

  • updated terminology in Bulk Action and More Action pop-over
    image
    image

  • removed padding in end of Acknowledged
    image

Build Details:

Version:7.15.0 BC2
Commit:113d5f2a745ab9be7d567d13ff906dfd0f5b7a9a
Build:43742

Hence closing this issue.

thanks !!

@ghost ghost closed this as completed Aug 25, 2021
@ghost ghost added the QA:Validated Issue has been validated by QA label Aug 25, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience fixed QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team Theme: rac label obsolete v7.15.0
Projects
None yet
Development

No branches or pull requests

6 participants