Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAC] Actions popovers UI unification #109221

Merged
merged 10 commits into from
Aug 23, 2021
Merged

[RAC] Actions popovers UI unification #109221

merged 10 commits into from
Aug 23, 2021

Conversation

semd
Copy link
Contributor

@semd semd commented Aug 19, 2021 •
edited
Loading

Summary

Uniformization of all RAC actions popovers.
Solves #108912

  • Bulk actions:
    bulk_actions
  • Observability Alerts row
    o11y_actions
  • Security Solutions Alerts row
    secsol_action
  • Flyout take action:
    flyout_take_action

Checklist

Delete any items that are not applicable to this PR.

@semd semd added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed Theme: rac label obsolete v7.15.0 v7.16.0 labels Aug 19, 2021
@semd semd self-assigned this Aug 19, 2021
@semd semd requested a review from a team as a code owner August 19, 2021 10:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@semd semd mentioned this pull request Aug 19, 2021
Closed
@semd semd changed the title [RAC] Actions popovers UI unification WIP [RAC] Actions popovers UI unification Aug 19, 2021
@semd semd requested a review from a team as a code owner August 20, 2021 09:51
@semd semd changed the title WIP [RAC] Actions popovers UI unification [RAC] Actions popovers UI unification Aug 20, 2021
@semd
Copy link
Contributor Author

semd commented Aug 20, 2021

@elasticmachine merge upstream

@angorayc
Copy link
Contributor

@elasticmachine merge upstream

angorayc
angorayc approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All work as expected, I removed some files that no longer used.

@angorayc angorayc enabled auto-merge (squash) August 23, 2021 10:51
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2371 2369 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 492.1KB 492.2KB +12.0B
securitySolution 6.5MB 6.5MB -578.0B
timelines 437.2KB 437.2KB +3.0B
total -563.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
timelines 317.9KB 317.8KB -27.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

@angorayc angorayc merged commit 64dff78 into elastic:master Aug 23, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2021
@semd @kibanamachine @angorayc
[RAC] Actions popovers UI unification (elastic#109221)
93b310e 
* popover padding size unified

* remove panels from all context menus

* action items order changed

* cases menu items test fixed

* translations and small changes

* remove components not used anywhere

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>
@kibanamachine kibanamachine mentioned this pull request Aug 23, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2021
@semd @kibanamachine @angorayc
[RAC] Actions popovers UI unification (elastic#109221)
be39c6e 
* popover padding size unified

* remove panels from all context menus

* action items order changed

* cases menu items test fixed

* translations and small changes

* remove components not used anywhere

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>
@kibanamachine kibanamachine mentioned this pull request Aug 23, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 23, 2021
@kibanamachine @semd @angorayc
[RAC] Actions popovers UI unification (#109221) (#109637)
1956c46 
* popover padding size unified

* remove panels from all context menus

* action items order changed

* cases menu items test fixed

* translations and small changes

* remove components not used anywhere

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>

Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>
kibanamachine added a commit that referenced this pull request Aug 24, 2021
@kibanamachine @semd @angorayc
[RAC] Actions popovers UI unification (#109221) (#109638)
58948b0 
* popover padding size unified

* remove panels from all context menus

* action items order changed

* cases menu items test fixed

* translations and small changes

* remove components not used anywhere

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>

Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>
@semd semd mentioned this pull request Aug 24, 2021
Closed
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

Assignees

@semd semd

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team Theme: rac label obsolete v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@semd @elasticmachine @angorayc @kibanamachine