Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] [Kibana Analytics] Show consistent empty state when no data #111184

Open
6 of 12 tasks
ryankeairns opened this issue Sep 3, 2021 · 9 comments
Open
6 of 12 tasks

[META] [Kibana Analytics] Show consistent empty state when no data #111184

ryankeairns opened this issue Sep 3, 2021 · 9 comments
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@ryankeairns
Copy link
Contributor

ryankeairns commented Sep 3, 2021

Relates to #111374 #111158 #109523

Target empty state design for Analytics apps

For no data, no index patterns

  1. Navigate to an Analytics app (Discover, Dashboard, etc.)
  2. See the new empty state design (below) as it was implemented on the Analytics Overview page

Screen Shot 2022-01-13 at 10 29 13 AM

For have data, no index patterns

  1. Navigate to an Analytics app
  2. Show an in-app EuiEmptyPrompt , similar to this, with a link to 'Create an index pattern'
  3. Clicking the link/button in the empty prompt opens the existing Create and index pattern flyout.

7.16 Analytics no-data changes

Shared components and services

The default approach for all Analytics apps will be to show the same no-data view (based upon the KibanaPageLayoutTemplate). This insures that users will get the same experience, across all apps, which steers them towards the 'Add data' view. At a future time, this will be changed to route them to the 'Integrations' view.

Apply shared components and service to applications

Each Analytics application will need to use the isNewKibanaInstance to conditionally show the shared, no-data view

Related work

Create index patterns: empty state

We also need to simplify the empty state in the 'Create index pattern' flyout. Move the empty state back into the page; reserve the flyout for in-app use, etc.

Create index patterns: integrated in apps

Separately, we should make additional issue(s) for adding 'Create an index pattern' to both an application's empty state (for the has data, no index pattern use case) and to the overflow menu that exists alongside Index Pattern selector UIs

@ryankeairns ryankeairns added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Sep 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@ryankeairns ryankeairns added the Feature:Discover Discover Application label Sep 3, 2021
@ryankeairns ryankeairns changed the title [Disocver] Update empty state to include create index pattern UX [Kibana Analytics] Show consistent empty state when no data Sep 14, 2021
@ryankeairns ryankeairns added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Sep 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Kibana-Design)

@ryankeairns ryankeairns self-assigned this Sep 14, 2021
@ryankeairns ryankeairns changed the title [Kibana Analytics] Show consistent empty state when no data [META] [Kibana Analytics] Show consistent empty state when no data Sep 14, 2021
@ryankeairns ryankeairns removed their assignment Sep 14, 2021
@alexfrancoeur
Copy link

@clintandrewhall @thomasneirynck @ryankeairns @snide what is the possibility we could still backport this to 7.16? And if not, how about 8.0?

@timroes timroes removed Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Nov 5, 2021
@LL6688
Copy link

LL6688 commented Jan 25, 2022

@clintandrewhall @alexfrancoeur will we have this in 8.1?

@alexfrancoeur
Copy link

@majagrubic would you say #123366 addresses this issue?

@LL6688
Copy link

LL6688 commented Jan 28, 2022

@majagrubic would you say #123366 addresses this issue?

@majagrubic
Copy link
Contributor

@LL6688 it's a partial solution for the first part of the probem - "no data, no index patterns"
Second part is blocked by #124019

@majagrubic
Copy link
Contributor

majagrubic commented Feb 2, 2022

To write a more detailed summary of this:
We want to distinguish between two states:

  1. No user-created data views and no data in ES (ie. fresh Kibana instance with no integrations)
  2. There is data in ES, but no data views yet

For now, we have implemented a redirect to Overview page from Discover for case 1. We agreed this would be the fastest way forward and good enough for now.

Use case 2 is a bit more tricky, as there is no standard way to check whether there is data in ES, but no data views.
Given we want to implement this for every Analytics app, we'd ideally like to standardize and reuse this check. Data views editor has implemented something like this in one of their components, but we can't have every app copy this code. App-services has agreed to take on building a service that would expose this check (tracked in this issue)

After the service has been implemented, the remaining steps would be:

  • create an empty view to display in case 1 (to avoid redirect)
  • create an empty view to display in case 2
  • have these views adopted by all Analytics apps

@rayafratkina
Copy link
Contributor

Potential blockers in the API tracked in #132478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

No branches or pull requests

7 participants