Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[index patterns] index pattern create modal #101853

Merged
merged 178 commits into from
Aug 6, 2021

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Jun 10, 2021

Summary

Index pattern creation modal - create index patterns from any kibana app. Initial implementation in index pattern management.

Closes #84725

Screen Shot 2021-06-28 at 10 07 06 PM

To test

  • Go to index pattern management
    • Without any data
    • With data but without index patterns
  • Click 'Create index pattern'
    • Things should be familiar from here, similar to existing index pattern creation UI

Test with index w/o a time field -

create an index without a time field -

PUT my-index-000001/_doc/1?refresh
{
  "my_id": "1",
  "email": "billgates@ms.com"
}

Test with a rollup index

  • Install ecommerce sample data
  • Go to Management / Rollup Jobs and create a new rollup job

Checklist

Delete any items that are not applicable to this PR.

mattkime and others added 30 commits June 8, 2021 15:02
…om:mattkime/kibana into rollup_creation_code_to_index_pattern_mgmt
@alexfrancoeur
Copy link

@mattkime does this also include an inline editing experience or just create? There are a variety of use cases in which (in context) one might want to modify a field in an index pattern.

@mattkime
Copy link
Contributor Author

mattkime commented Aug 5, 2021

@alexfrancoeur This is just create. We also have the index pattern field editor but it assumes the app provides the field list. If something new is needed lets talk.

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

<span>
<FormattedMessage
id="indexPatternEditor.status.notMatchLabel.notMatchDetail"
defaultMessage="The index pattern you've entered doesn't match any indices, data streams, or index aliases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
defaultMessage="The index pattern you've entered doesn't match any indices, data streams, or index aliases.
defaultMessage="The index pattern you entered doesn't match any data streams, indices, or aliases.

id="indexPatternManagement.createIndexPattern.step.status.noSystemIndicesWithPromptLabel"
defaultMessage="No Elasticsearch indices match your pattern. To view the matching system indices, toggle the switch above."
id="indexPatternEditor.status.noSystemIndicesWithPromptLabel"
defaultMessage="No Elasticsearch indices match your pattern."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is indices correct here? Or is it data streams, indices, or aliases?

/>
</span>
);
} else {
statusMessage = (
<span>
<FormattedMessage
id="indexPatternManagement.createIndexPattern.step.status.noSystemIndicesLabel"
id="indexPatternEditor.status.noSystemIndicesLabel"
defaultMessage="No Elasticsearch indices match your pattern."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above.

id="indexPatternManagement.createIndexPattern.step.status.partialMatchLabel.partialMatchDetail"
defaultMessage="Your index pattern doesn't match any indices, but you have {strongIndices} which
id="indexPatternEditor.status.partialMatchLabel.partialMatchDetail"
defaultMessage="Your index pattern doesn't match any sources, but you have {strongIndices} which
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does something like this work?

Your index pattern doesn't match any data streams, indices, or aliases, but some sources are similar.

<FormattedMessage
id="indexPatternEditor.status.notMatchLabel.notMatchDetail"
defaultMessage="The index pattern you've entered doesn't match any indices, data streams, or index aliases.
You can match {strongIndices}, below."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if this is a data stream or alias? Available matches are below?

mattkime and others added 7 commits August 5, 2021 18:57
…ts/empty_index_pattern_prompt/empty_index_pattern_prompt.tsx

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
…/timestamp_field.tsx

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
…/timestamp_field.tsx

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
…/title_field.tsx

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
indexPatternEditor - 104 +104
indexPatternManagement 167 85 -82
total +22

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexPatternEditor - 169.3KB +169.3KB
indexPatternManagement 547.4KB 384.6KB -162.7KB
total +6.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 791.1KB 791.3KB +228.0B
indexPatternEditor - 21.0KB +21.0KB
indexPatternManagement 19.2KB 6.9KB -12.3KB
total +8.9KB
Unknown metric groups

API count

id before after diff
core 2454 2455 +1
data 3713 3721 +8
total +9

API count missing comments

id before after diff
core 1165 1166 +1
data 3195 3203 +8
total +9

async chunk count

id before after diff
indexPatternEditor - 2 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit d44df74 into elastic:master Aug 6, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 101853

mattkime added a commit to mattkime/kibana that referenced this pull request Aug 6, 2021
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 9, 2021
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (392 commits)
  update linting doc (elastic#105748)
  [APM] Various improvements from elastic#104851 (elastic#107726)
  Update dependency @elastic/charts to v33.2.0 (master) (elastic#107842)
  Fix default route link on kibana homepage (elastic#107809)
  [APM] Invalidate trackPageview on route change (elastic#107741)
  Service map backend links (elastic#107317)
  [index patterns] index pattern create modal (elastic#101853)
  [RAC] integrating rbac search strategy with alert table (elastic#107242)
  [Security Solution] Siem signals -> alerts as data field and index aliases (elastic#106049)
  [Metrics UI] Add checkbox to optionally drop partial buckets (elastic#107676)
  [Metrics UI] Fix metric threshold preview regression (elastic#107674)
  Disable Product check in @elastic/elasticsearch-js (elastic#107642)
  [App Search] Migrate Crawler Status Indicator, Crawler Status Banner, and Crawl Request polling (elastic#107603)
  [Security Solution, Lists] Replace legacy imports from 'elasticsearch' package (elastic#107226)
  [maps] asset tracking tutorial (elastic#104552)
  [scripts/build_ts_refs] when using `--clean` initialize caches (elastic#107777)
  Upgrade EUI to v36.1.0 (elastic#107231)
  [RAC] [TGrid] Implements cell actions in the TGrid (elastic#107771)
  Realign cypress/ccs_integration with cypress/integration (elastic#107743)
  Allow optional OSS to X-Pack dependencies (elastic#107432)
  ...

# Conflicts:
#	x-pack/examples/reporting_example/public/application.tsx
#	x-pack/examples/reporting_example/public/components/app.tsx
#	x-pack/plugins/canvas/public/services/legacy/stubs/reporting.ts
#	x-pack/plugins/reporting/common/types.ts
#	x-pack/plugins/reporting/public/lib/reporting_api_client/context.tsx
#	x-pack/plugins/reporting/public/management/mount_management_section.tsx
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
#	x-pack/plugins/reporting/public/plugin.ts
#	x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
#	x-pack/plugins/reporting/server/export_types/printable_pdf/execute_job/index.ts
mattkime added a commit that referenced this pull request Aug 9, 2021
* [index patterns] index pattern create modal (#101853)

index pattern creation flyout

* update docs

* update limits

* Update limits.yml

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[index patterns] Create index pattern flyout