Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Fix confusing throughput #104851

Closed
wants to merge 1 commit into from
Closed

[APM] Fix confusing throughput #104851

wants to merge 1 commit into from

Conversation

sorenlouv
Copy link
Member

WIP - probably won't be merged as-is but broken into smaller PRs.

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 8, 2021 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/apm/public/services/rest.Observability dashboard data fetchObservabilityOverviewPageData returns APM data with series and stats

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: Cannot read property 'value' of undefined
    at fetchObservabilityOverviewPageData (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/apm/public/services/rest/apm_observability_overview_fetchers.ts:42:27)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/apm/public/services/rest/apm_observability_overview_fetchers.test.ts:59:24)
Kibana Pipeline / jest / Jest Tests.x-pack/plugins/apm/public/services/rest.Observability dashboard data fetchObservabilityOverviewPageData returns empty transaction coordinates

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: Cannot read property 'value' of undefined
    at fetchObservabilityOverviewPageData (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/apm/public/services/rest/apm_observability_overview_fetchers.ts:42:27)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/apm/public/services/rest/apm_observability_overview_fetchers.test.ts:90:24)
Kibana Pipeline / jest / Jest Tests.x-pack/plugins/apm/public/services/rest.Observability dashboard data fetchObservabilityOverviewPageData returns transaction stat as 0 when y is undefined

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: Cannot read property 'value' of undefined
    at fetchObservabilityOverviewPageData (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/apm/public/services/rest/apm_observability_overview_fetchers.ts:42:27)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/apm/public/services/rest/apm_observability_overview_fetchers.test.ts:120:24)

and 7 more failures, only showing the first 3.

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB +197.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv mentioned this pull request Aug 5, 2021
Merged
sorenlouv added a commit that referenced this pull request Aug 7, 2021
@sorenlouv
[APM] Various improvements from #104851 (#107726)
b16d20b
@kibanamachine kibanamachine mentioned this pull request Aug 7, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 7, 2021
@sorenlouv @kibanamachine
[APM] Various improvements from elastic#104851 (elastic#107726)
6b9cf0c
@sorenlouv
Copy link
Member Author

Replaced by #107850 and #107726

@sorenlouv sorenlouv closed this Aug 7, 2021
@sorenlouv sorenlouv deleted the convert-tpm-to-tps branch August 7, 2021 11:34
kibanamachine added a commit that referenced this pull request Aug 7, 2021
@kibanamachine @sorenlouv
[APM] Various improvements from #104851 (#107726) (#107851)
575993d 
Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@sorenlouv @vadimkibana
[APM] Various improvements from elastic#104851 (elastic#107726)
5f4d680
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 9, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/new…
699d458 
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (392 commits)
  update linting doc (elastic#105748)
  [APM] Various improvements from elastic#104851 (elastic#107726)
  Update dependency @elastic/charts to v33.2.0 (master) (elastic#107842)
  Fix default route link on kibana homepage (elastic#107809)
  [APM] Invalidate trackPageview on route change (elastic#107741)
  Service map backend links (elastic#107317)
  [index patterns] index pattern create modal (elastic#101853)
  [RAC] integrating rbac search strategy with alert table (elastic#107242)
  [Security Solution] Siem signals -> alerts as data field and index aliases (elastic#106049)
  [Metrics UI] Add checkbox to optionally drop partial buckets (elastic#107676)
  [Metrics UI] Fix metric threshold preview regression (elastic#107674)
  Disable Product check in @elastic/elasticsearch-js (elastic#107642)
  [App Search] Migrate Crawler Status Indicator, Crawler Status Banner, and Crawl Request polling (elastic#107603)
  [Security Solution, Lists] Replace legacy imports from 'elasticsearch' package (elastic#107226)
  [maps] asset tracking tutorial (elastic#104552)
  [scripts/build_ts_refs] when using `--clean` initialize caches (elastic#107777)
  Upgrade EUI to v36.1.0 (elastic#107231)
  [RAC] [TGrid] Implements cell actions in the TGrid (elastic#107771)
  Realign cypress/ccs_integration with cypress/integration (elastic#107743)
  Allow optional OSS to X-Pack dependencies (elastic#107432)
  ...

# Conflicts:
#	x-pack/examples/reporting_example/public/application.tsx
#	x-pack/examples/reporting_example/public/components/app.tsx
#	x-pack/plugins/canvas/public/services/legacy/stubs/reporting.ts
#	x-pack/plugins/reporting/common/types.ts
#	x-pack/plugins/reporting/public/lib/reporting_api_client/context.tsx
#	x-pack/plugins/reporting/public/management/mount_management_section.tsx
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
#	x-pack/plugins/reporting/public/plugin.ts
#	x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
#	x-pack/plugins/reporting/server/export_types/printable_pdf/execute_job/index.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorenlouv @kibanamachine