Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discuss] Index pattern creation dialog #67711

Closed
mattkime opened this issue May 28, 2020 · 15 comments
Closed

[discuss] Index pattern creation dialog #67711

mattkime opened this issue May 28, 2020 · 15 comments
Assignees
Labels
discuss Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@mattkime
Copy link
Contributor

mattkime commented May 28, 2020

What if you could create an index patttern from within various kibana applications via a dialog box?

I think the index pattern creation flow would be easy to translate to visually smaller design. There are only two steps:

  • Enter wildcard / show selected indices
  • Select time stamp field

Primary benefit - reduction of context switching. Currently, you you must go to Stack Management / Index Patterns and then navigate back to your task.

Alternative - perhaps another non modal UI would work as well, such as an interface where you simply provide the wildcard pattern and timestamp and there's a greater assumption that the user knows what they're doing.

Current flow -

Initial view
Screen Shot 2020-05-28 at 4 18 40 PM

Wildcard entered, showing matches
Screen Shot 2020-05-28 at 4 18 54 PM

Select timestamp field
Screen Shot 2020-05-28 at 4 19 14 PM

@mattkime mattkime added discuss Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Data Views Data Views code and UI - index patterns before 8.0 labels May 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mattkime mattkime mentioned this issue Jun 2, 2020
12 tasks
@mattkime
Copy link
Contributor Author

mattkime commented Jul 21, 2020

Owners
@mattkime - Primary owner
@miukimiu - Owns design deliverables

Timeline and deliverables
Wireframes - Sept 14th

Target outcomes
Goal - Create index pattern without changing context

@cchaos
Copy link
Contributor

cchaos commented Aug 6, 2020

Related issue(s):

@miukimiu
Copy link
Contributor

@mattkime and @cchaos,

Here's my initial wireframes/prototype: figma. (anyone at elastic can see the prototype)

My initial thoughts:

  • I'm basically using what is already done in management. So we could share the code.
  • A modal would be too small so I picked a flyout
  • There's a confirmation step where we confirm that the index pattern was created with success. I'm not completely sure about the "There's more you can do". But the idea was to show that there are more fields that users can create.

@miukimiu
Copy link
Contributor

@mattkime, @cchaos, and @AlonaNadler,

We have the initial wireframes/prototype and the last screen, is basically to confirm that the index pattern was successfully created.

I think it would be great to also display a few calls to actions because there's more a user can do to the index pattern. This is the initial idea:

Discover A4

So I'm not completely sure if we should display the "There's more you can do" or if we display what are the right CTAs. Any thoughts?

@mattkime
Copy link
Contributor Author

I think it looks good (although I'm uncertain about the CTAs) - but wanted to mention that this should work for empty data / index pattern cases.

@miukimiu
Copy link
Contributor

Yes @mattkime, I'll create more user flows for empty data / index pattern cases.

@elastic-jb
Copy link

@mattkime @miukimiu @AlonaNadler I like the design, and the call to action idea. It doesn't have to be a call to action style, but I like a quick way to create a scripted field or source field.

That being said, what about formatting? I feel like that is more common. I need to change the type and modify the formatting at least once when I create an index pattern to get a percentage to show correctly, or trim decimals a bit to get things to look more consistent. In that case, this dialog saves me from having to go to Stack Management to create the index pattern, but I still have to go there once it's created to get my visualizations to format numbers correctly.

It would be great if there was a more streamlined way make bulk changes to formatting. Just recently I found myself having to re-create index patterns for a demo and each time I had to go through 4 pages of fields and every time I edit one, it would restart the pagination at page 1. Luckily the table shows you when a format has been set, but it is still a frustrating experience if you need to edit more than one ore two. I was editing over a dozen in this case.

Giving users an optional experience to edit field format types, and making it easy to edit several fields quickly would be a big win. I would say that goes for any index creation dialog, not just this one.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@timroes timroes removed the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Oct 5, 2020
@mattkime mattkime changed the title [DISCUSS] Index pattern creation dialog Index pattern creation dialog Dec 2, 2020
@mattkime mattkime changed the title Index pattern creation dialog [discuss] Index pattern creation dialog Dec 2, 2020
@mattkime
Copy link
Contributor Author

I'm picking this up for 7.14 and have a couple of thoughts

@ryankeairns
Copy link
Contributor

@mattkime The Kibana Design team will be picking this up from @miukimiu . How soon will you be starting work on your side of things?

@mattkime
Copy link
Contributor Author

@ryankeairns I'm hoping to start working on this in three weeks. It would be nice to have the design complete four weeks from now, if possible. I'll be out April 26th through May 7th.

@andreadelrio
Copy link
Contributor

After a couple of iterations, consulting with @mattkime and getting feedback on a design critique, here are the designs that I'm proposing.

Most up to date Figma prototype can be found here.

flow2

Things to consider

  • We'll be using a side panel next to a flyout, following the same pattern proposed by Dmitry for Runtime fields preview.
  • The panel appears to the right of the flyout.
  • The flyout doesn't have an (x) button, only a Cancel/Close button on the footer.
  • By default, the side panel show the list of indices the user can match with their pattern. As they input a pattern name the content of the side panel is refreshed and shows the results of the match.
  • Upon successfully creating a new index pattern, the user receives a toast and is shown that index pattern (if on Discover).
  • The time field dropdown is disabled until the user has input an index pattern name. While it is disabled we show a tooltip explaining why it is disabled.

tooltip

  • Include system and hidden indices switch moves to Advanced Settings

image

  • First index pattern view (copy to be adjusted for this specific use case)
    image

@mattkime
Copy link
Contributor Author

mattkime commented Jun 8, 2021

Thanks @andreadelrio , this looks great!

The first index pattern view - I think it should be in the flyout. The index pattern creation modal provides a single API call to display anything index pattern creation related. Doing anything outside of that flyout requires additional integration from each consuming app, potentially every app that uses index patterns.

@exalate-issue-sync exalate-issue-sync bot added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jun 21, 2021
@mattkime
Copy link
Contributor Author

mattkime commented Oct 7, 2021

implemented - #101853

@mattkime mattkime closed this as completed Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Development

No branches or pull requests

8 participants