Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Could not save changes when editing Anomaly Detection job's datafeed #118427

Closed
qn895 opened this issue Nov 11, 2021 · 4 comments · Fixed by #119515
Closed

[ML] Could not save changes when editing Anomaly Detection job's datafeed #118427

qn895 opened this issue Nov 11, 2021 · 4 comments · Fixed by #119515
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml v8.0.0 v8.1.0

Comments

@qn895
Copy link
Member

qn895 commented Nov 11, 2021

Kibana version: main

Elasticsearch version: 8.1.0

Steps to reproduce:

  1. Start a Anomaly detection job and start and stop the datafeed
  2. Edit the job's datafeed then save

Expected behavior:
The new datafeed query should be saved

Screenshots (if relevant):
Screen Shot 2021-11-11 at 14 02 01

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

@qn895 qn895 added bug Fixes for quality problems that affect the customer experience :ml labels Nov 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic
Copy link
Member

jgowdyelastic commented Nov 12, 2021

This has been broken by a change in the elasticsearch client in 8.0.0.
the updateDatafeed function in the client now ignores the body which is passed to it:
https://github.com/elastic/elasticsearch-js/blob/88933ad39e4ff7d8d3f74a1280e4d5fd00910055/src/api/api/ml.ts#L1936

Compared to 7.16 where the body is being used:
https://github.com/elastic/elasticsearch-js/blob/6020625912153a1b1c8d77c397a14f3dbb8f2b8b/api/api/ml.js#L1720

I wouldn't consider this a blocker for 8.0.0, as editing the datafeed for existing jobs isn't a high profile feature but it would be good to get it fixed for 8.0.0 if possible.
cc @sophiec20 @peteharverson

@delvedor would it be possible to get this fixed in the client for 8.0?

@jgowdyelastic
Copy link
Member

API tests is missing for this endpoint.
I've added an item for to add tests for 8.0.0
#117930

@peteharverson peteharverson changed the title [ML] Could not save changes when editting Anomaly Detection job's datafeed [ML] Could not save changes when editing Anomaly Detection job's datafeed Nov 15, 2021
@peteharverson peteharverson added the Feature:Anomaly Detection ML anomaly detection label Nov 15, 2021
@jgowdyelastic
Copy link
Member

Raised js client issue
elastic/elasticsearch-js#1601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants