Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixing update datafeed endpoint #119515

Merged
merged 4 commits into from
Nov 24, 2021
Merged

[ML] Fixing update datafeed endpoint #119515

merged 4 commits into from
Nov 24, 2021

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Nov 23, 2021 •
edited
Loading

Temporary work around for the incorrect esclient function updateDatafeed
The updateDatafeed function in the client currently ignores the body which is passed to it

Rather than using updateDatafeed we are now using transport.request to call the es endpoint directly.

Fixes #118427
Related to elastic/elasticsearch-js#1601

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience non-issue Indicates to automation that a pull request should not appear in the release notes release_note:fix :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Nov 23, 2021
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner November 23, 2021 17:12
@jgowdyelastic jgowdyelastic self-assigned this Nov 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic mentioned this pull request Nov 23, 2021
Closed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

peteharverson
peteharverson approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

darnautov
darnautov approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit 5b35ec7 into elastic:main Nov 24, 2021
@jgowdyelastic jgowdyelastic deleted the fixing-update-datafeed-endpoint branch November 24, 2021 14:16
@kibanamachine kibanamachine mentioned this pull request Nov 24, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 24, 2021
@jgowdyelastic @kibanamachine
[ML] Fixing update datafeed endpoint (elastic#119515)
c9a35c1 
* [ML] Fixing update datafeed endpoint

* adding comments

* using internal user

* updating comment
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 24, 2021
@kibanamachine @jgowdyelastic
[ML] Fixing update datafeed endpoint (#119515) (#119614)
10bd0ea 
* [ML] Fixing update datafeed endpoint

* adding comments

* using internal user

* updating comment

Co-authored-by: James Gowdy <jgowdy@elastic.co>
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
@jgowdyelastic @dmlemeshko
[ML] Fixing update datafeed endpoint (#119515)
76a3c8b 
* [ML] Fixing update datafeed endpoint

* adding comments

* using internal user

* updating comment
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@jgowdyelastic @TinLe
[ML] Fixing update datafeed endpoint (elastic#119515)
17570fa 
* [ML] Fixing update datafeed endpoint

* adding comments

* using internal user

* updating comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov darnautov approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:fix release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Could not save changes when editing Anomaly Detection job's datafeed
6 participants
@jgowdyelastic @elasticmachine @kibana-ci @kibanamachine @darnautov @peteharverson