Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Allow opting out of Data Views source configuration #120082

Closed
miltonhultgren opened this issue Dec 1, 2021 · 3 comments · Fixed by #124929
Closed

[Logs UI] Allow opting out of Data Views source configuration #120082

miltonhultgren opened this issue Dec 1, 2021 · 3 comments · Fixed by #124929
Assignees
@miltonhultgren
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@miltonhultgren
Copy link
Contributor

miltonhultgren commented Dec 1, 2021 •
edited
Loading

Based on #115737 we now allow (and encourage) users to opt into using Data Views for their source configuration, but once they opt in there is no way to opt back out for the given space. If we plan to continue supporting plain index names configuration it makes sense to allow the user to swap back to that option in the Settings page.

#115737 makes a note of future steps:

Use something like EuiCheckableCards to let the user choose between the two configuration styles at any time.

AC

  • It's possible to configure the source by selecting a Data View
  • There is a link to create a new Data View (and info is added about the privilege needed for this)
  • The Data View config is placed as the recommended option
  • It's possible to configure the source by using plain index names
  • It's possible to change a configuration from Data View to plain index names and vice versa

Note: We need to also check the write permissions for both Data View and Logs UI so that we offer options to the user only if they have the right access.
@miltonhultgren miltonhultgren added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Dec 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@miltonhultgren miltonhultgren self-assigned this Dec 1, 2021
@miltonhultgren miltonhultgren mentioned this issue Dec 1, 2021
Open
@miltonhultgren
Copy link
Contributor Author

miltonhultgren commented Dec 1, 2021 •
edited
Loading

(Optional) The "fallback" state is highlighted

This might be best done in a separate issue, since it applies to the whole Source Configuration, not only the index selection part.

@miltonhultgren miltonhultgren removed their assignment Jan 10, 2022
@miltonhultgren miltonhultgren self-assigned this Feb 4, 2022
@miltonhultgren
Copy link
Contributor Author

(Optional) The "fallback" state is highlighted

This won't be needed, as part of #98277 and #124011 we will make the configuration steps more fluent as part of prompting and eventually removing the Settings page in favor of Curated View editing.

miltonhultgren added a commit to miltonhultgren/kibana that referenced this issue Feb 8, 2022
@miltonhultgren
[Logs UI] Enable switching between log source modes (elastic#120082)
65d0396
@miltonhultgren miltonhultgren mentioned this issue Feb 8, 2022
Merged
7 tasks
miltonhultgren added a commit that referenced this issue Feb 15, 2022
@miltonhultgren @kibanamachine
[Logs UI] Support switching between log source modes (#124929)
f5041b4 
* [Logs UI] Enable switching between log source modes (#120082)

* [Logs UI] Improve Data view selection section  (#124251)

* Update translation files

* Apply review requests

Apply useCallback optimization
Add telemetry tracking for users opting out of data view usage
Remove extra visual space at the bottom of the card
Improve initial render state of data view panel

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miltonhultgren miltonhultgren

Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs UI] Support switching between log source modes miltonhultgren/kibana
2 participants
@miltonhultgren @elasticmachine