Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Broad version support for custom package policy editors in APM Fleet integration #123477

Closed
ogupte opened this issue Jan 20, 2022 · 2 comments
Assignees
Labels
apm:fleet enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support v8.2.0

Comments

@ogupte
Copy link
Contributor

ogupte commented Jan 20, 2022

The custom APM integration settings (create_apm_policy_form.tsx / edit_apm_policy_form.tsx) at /app/fleet/integrations/apm/add-integration, should be enhanced to support a broad range of apmpackage versions.

It's not uncommon for outdated or newer packages to be in use and could very well be out of sync with the stack version. It's also possible that new package versions that become available on the EPR are automatically updated on an agent policy, and we need to be tolerant of these cases.

The customized settings should include an "Other settings" catch-all, generic section for all input vars that are not already included in the above custom settings. There should also be guards in place that disables or hides inputs which are not supported in the APM package version that is currently being edited. The user should already be aware that an updated version exists since we set the useLatestPackageVersion setting on the edit UI where a section should be disabled. The create UI could simply hide these sections, since it's an advanced use case when the user is intentionally installing an outdated package version.

The current UI for fleet migration via the APM schema settings is hardcoded and should always use the latest available package (https://github.com/elastic/kibana/blob/main/x-pack/plugins/apm/common/fleet.ts#L11)

@ogupte ogupte added [zube]: Inbox apm:fleet enhancement New value added to drive a business result labels Jan 20, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 20, 2022
@ogupte ogupte added the Team:APM All issues that need APM UI Team support label Jan 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@ogupte ogupte removed the needs-team Issues missing a team label label Jan 20, 2022
@ogupte ogupte self-assigned this Feb 16, 2022
ogupte added a commit to ogupte/kibana that referenced this issue Mar 23, 2022
ogupte added a commit that referenced this issue Mar 28, 2022
…ation UI (#128339)

* [APM] Always uses the latest available apm package for the fleet migration UI (#123477)

* fixes linting error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@dannycroft
Copy link

Closing as the issue is marked as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:fleet enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support v8.2.0
Projects
None yet
Development

No branches or pull requests

3 participants