Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Align "row height" terminology to Discover, custom row heights #123654

Closed
Tracked by #57709
ghudgins opened this issue Jan 24, 2022 · 4 comments · Fixed by #127134
Closed
Tracked by #57709

[Lens] Align "row height" terminology to Discover, custom row heights #123654

ghudgins opened this issue Jan 24, 2022 · 4 comments · Fixed by #127134
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@ghudgins
Copy link
Contributor

Describe the feature:
As of 8.1 Lens will have an "auto row height" feature named "fit row to content" and is a toggle.
Update this toggle to be a triple (if custom is possible) or two mode selection to match Discover

Describe a specific use case for the feature:
When I am using both Discover and Lens
I need similar table controls to be consistent
So I can more reliably learn the user interface controls
And avoid getting confused by differently named controls for same functionality

Discover
image

Lens
image

CC @MichaelMarcialis for his thoughts on this

@ghudgins ghudgins added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jan 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@ghudgins ghudgins mentioned this issue Jan 24, 2022
29 tasks
@MichaelMarcialis
Copy link
Contributor

@ghudgins: Since we don't currently offer the EuiDataGrid controls for the component in Lens, I think your proposal to continue using the "Visual options" toolbar menu and updating the "Fit row to content" toggle to match the new row height options makes sense.

image

Out of curiosity, is there any desire to allow users to change these options from outside Lens (i.e. Dashboard)? If so, we may want to reconsider relegating it to the Lens toolbar (as that would not be directly available in the Dashboard app). I think we discussed this during the original proposal for the "Fit row to content" feature and the end result was that we only wanted to offer this functionality to visualization editors, but bringing it up again to double check.

@flash1293
Copy link
Contributor

@MichaelMarcialis It would reduce the density of the dashboard because of the lost vertical space in case you don't need it - do you think that would be an issue?

@ghudgins
Copy link
Contributor Author

is there any desire to allow users to change these options from outside Lens

yes but I would still like to also be able to edit this in a single visualization context (the toolbar where it is today).

we're starting to build a list of these features we want to "override" on Dashboards in bulk. Might make sense to begin tracking them somewhere (like a meta?). @flash1293 what do you think? I can add this to one of our weeklies to talk about how best to move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants