-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Improve Datatable content height with custom row height #127134
Conversation
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kibina gis changes LGTM
code review
x-pack/plugins/lens/public/datatable_visualization/components/toolbar.tsx
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
@flash1293 fixed the issue. |
💚 Build SucceededMetrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works as expected, LGTM
Summary
Fixes #123654
This PR introduces a new
Custom
option for the Lens datatable row height, aligning the configuration UI to the Discover/EUI one.By default the option is set to
single
:It is possible to change the option to
Auto
, which maps to previousFit row to content
.The new
Custom
option will default to 2 lines, but it can go up to 20, with a minimum value of 1:In order to better handle the new state the previous
fitRowToContent
state prop has been migrated to a combination of these new props:Note that
rowHeightLines
is ignored when therowHeight
prop is set toAuto
even when forwarded to the table visualization code.Note: there's a known bug with the
Custom
option when shrinking down the height. It seems to be a EUI bug (issue TBD)Note 2: since introducing the custom row height this error appeared from Jest execution:
I've tried to fix as in EUI exposing the
_isJest
flag on Jest setup, but that didn't work.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers