Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XY] Percentiles with decimals do not work any more in visualize #123700

Closed
dej611 opened this issue Jan 25, 2022 · 4 comments · Fixed by #123709
Closed

[XY] Percentiles with decimals do not work any more in visualize #123700

dej611 opened this issue Jan 25, 2022 · 4 comments · Fixed by #123709
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:XYAxis XY-Axis charts (bar, area, line) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@dej611
Copy link
Contributor

dej611 commented Jan 25, 2022

Kibana version: 7.16.0

Describe the bug:

In Visualizes/Aggregation based visualizations percentile values do not work any more with decimals.

Percentile values like 1.5 or 99.5 used to work until 7.16.0, but now they are no longer: the current problem is probably relative no a missing column mapping in the final visualization code.

Screenshot 2022-01-25 at 11 49 06

In percentiles column ids are matched with some string manipulation, which is probably going wrong this time.

As result the chart is removing the percentile column with decimals.

@dej611 dej611 added bug Fixes for quality problems that affect the customer experience Feature:XYAxis XY-Axis charts (bar, area, line) Team:Visualizations Visualization editors, elastic-charts and infrastructure impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jan 25, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@flash1293
Copy link
Contributor

Yep, seems like the logic here just splits by . which is not enough:

(columnId || '').toString().split('.')[0];

@flash1293
Copy link
Contributor

@dej611 @stratoula While testing the fix, I noticed percentage mode on an axis doesn't work right as well for multi-value metrics - is this a known problem?

Like in this example:
Screenshot 2022-01-25 at 13 17 22

Count metrics are respecting percentage mode, but percentiles don't. We don't have to fix it in the same PR necessarily, I can't think of a good use case to use percentage mode for percentile/percentile ranks, but still.

@stratoula
Copy link
Contributor

@flash1293 yes this seems to be a bug of the normal mode. Stacked mode works correctly on my local branch. Do you want me to create an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:XYAxis XY-Axis charts (bar, area, line) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants