Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XY Fix percentile with decimals #123709

Merged
merged 5 commits into from
Jan 26, 2022
Merged

XY Fix percentile with decimals #123709

merged 5 commits into from
Jan 26, 2022

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Jan 25, 2022 •
edited
Loading

Fixes #123700

This PR makes sure also percentiles and percentile ranks with decimal points.

To test:

  • Percentiles with and without decimal points
  • Percentile ranks with and without decimal points
  • Multiple percentile/percentile ranks aggs with decimal points in a single chart
  • Percentile/percentile ranks with decimal points together with series and chart splits
  • Multiple percentile/percentile ranks aggs with decimal points in a single chart with mulitple axes, both with and without series/chart splits
  • Multiple percentile/percentile ranks aggs with decimal points in a single chart with mulitple axes, some of them percentage based, both with and without series/chart splits - this doesn't work, but probably unrelated to this PR [XY] Percentiles with decimals do not work any more in visualize #123700 (comment)

@flash1293 flash1293 added Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v8.1.0 v7.17.0 labels Jan 25, 2022
@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review January 25, 2022 15:29
@flash1293 flash1293 requested a review from a team as a code owner January 25, 2022 15:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@flash1293 flash1293 added Feature:XYAxis XY-Axis charts (bar, area, line) and removed Feature:TSVB TSVB (Time Series Visual Builder) labels Jan 25, 2022
dej611
dej611 reviewed Jan 25, 2022
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review looks ok. Will check it locally

stratoula
stratoula approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, I tested it locally and percentiles and percentile ranks work with decimals now 👍

@flash1293 @dej611
Update src/plugins/vis_types/xy/public/utils/accessors.tsx
ed5fb83 
Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293 flash1293 added the auto-backport Deprecated - use backport:version if exact versions are needed label Jan 26, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeXy 61.4KB 61.5KB +107.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit 03c8d08 into elastic:main Jan 26, 2022
@kibanamachine kibanamachine mentioned this pull request Jan 26, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 26, 2022
@flash1293 @kibanamachine
XY Fix percentile with decimals (elastic#123709)
f8987b7 
(cherry picked from commit 03c8d08)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 26, 2022
@flash1293 @kibanamachine
XY Fix percentile with decimals (elastic#123709)
25d3e2a 
(cherry picked from commit 03c8d08)
@kibanamachine kibanamachine mentioned this pull request Jan 26, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.0
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 26, 2022
@kibanamachine @flash1293
XY Fix percentile with decimals (#123709) (#123807)
919c0d0 
(cherry picked from commit 03c8d08)

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
kibanamachine added a commit that referenced this pull request Jan 26, 2022
@kibanamachine @flash1293
XY Fix percentile with decimals (#123709) (#123808)
15aaeeb 
(cherry picked from commit 03c8d08)

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 left review comments

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:XYAxis XY-Axis charts (bar, area, line) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.17.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[XY] Percentiles with decimals do not work any more in visualize
6 participants
@flash1293 @elasticmachine @kibana-ci @kibanamachine @dej611 @stratoula