Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Extract/inject references from server side embeddable #124976

Closed
crob611 opened this issue Feb 8, 2022 · 3 comments
Closed

[Maps] Extract/inject references from server side embeddable #124976

crob611 opened this issue Feb 8, 2022 · 3 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v8.0.0 v8.1.0

Comments

@crob611
Copy link
Contributor

crob611 commented Feb 8, 2022

Canvas handles reference extraction and injection server side.

It doesn't appear that maps implements either inject or extract for the server side embeddable, so a workpad with a by value map embeddable that is exported is missing references from the map.

@crob611 crob611 added bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Feb 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. v7.17.0 v8.0.0 v8.1.0 labels Feb 14, 2022
@nreese nreese self-assigned this Feb 14, 2022
@nreese nreese added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v8.0.0 v8.1.0 and removed v8.0.0 v8.1.0 v7.17.0 impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Feb 14, 2022
@nreese
Copy link
Contributor

nreese commented Feb 14, 2022

Background

Canvas added support for by-value embeddable in 8.0. Canvas uses server embeddable to extract references from embeddable. Since maps does not register extract in server-side embeddable, by-value maps embedded in canvas will not expose index pattern references to canvas. This will only effect newly created canvas in 8.0 and onwards that use by-value maps.

Original extract logic added to client embeddables in #91567 (7.12).

Lens inject logic to client embeddable and extract/inject logic added to server embeddable with #96703 (7.15).

Looks like maps team missed the requirement for exposing extract/inject logic in the server maps embeddable.

@nreese
Copy link
Contributor

nreese commented Feb 17, 2022

Closed by #125599

@nreese nreese closed this as completed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v8.0.0 v8.1.0
Projects
None yet
Development

No branches or pull requests

3 participants