[Dashboard] Export appropriate references from byValue panels #91567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crob611
force-pushed
the
by-value-export-references
branch
from
7548607
to
7ec4f0b
Compare
crob611
added
bug
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
crob611
added
the
release_note:skip
|
@elasticmachine merge upstream |
flash1293
approved these changes
Feb 22, 2021
| let references: SavedObjectReference[] = []; | ||
| const typedState = (state as unknown) as LensEmbeddableInput; | ||
|
|
||
| if ((typedState as LensByValueInput).attributes !== undefined) { |
There was a problem hiding this comment.
nit: You can get around these two type casts by checking for by value input like this:
'attributes' in typedState && typedState.attributes
It's turned into a type guard automatically by typescript, so you won't need to case again in the branch
There was a problem hiding this comment.
Ohh nice. That's very handy to know.
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
crob611
added
the
auto-backport
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2021
…c#91567) * Adds references from byValue panels when saving dashboard * Remove extra spaces * Rework a type check * Fix type check Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This was referenced Feb 24, 2021
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2021
…c#91567) * Adds references from byValue panels when saving dashboard * Remove extra spaces * Rework a type check * Fix type check Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Feb 24, 2021
#92713) * Adds references from byValue panels when saving dashboard * Remove extra spaces * Rework a type check * Fix type check Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Corey Robertson <corey.robertson@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 24, 2021
#92714) * Adds references from byValue panels when saving dashboard * Remove extra spaces * Rework a type check * Fix type check Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Corey Robertson <corey.robertson@elastic.co>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 25, 2021
* master: (38 commits) Fixes Cypress flake by adding pipe, click, and should (elastic#92762) [Discover] Fix filtering selected sidebar fields (elastic#91828) [ML] Fixes positions of calendar arrow buttons in start datafeed modal (elastic#92625) [dev/build_ts_refs] check that commit in outDirs matches mergeBase (elastic#92513) add dep on `@kbn/config` so it is built first [Expressions] [Lens] Add id and copyMetaFrom arg to mapColumn fn + add configurable onError argument to math fn (elastic#90481) [Lens] Fix Workspace hidden when using Safari (elastic#92616) [Lens] Fixes vertical alignment validation messages (elastic#91878) forbid x-elastic-product-origin header in elasticsearch configuration (elastic#92359) [Security Solution][Detections] Set default indicator path to reduce friction with new filebeat modules (elastic#92081) [ILM][Accessibility] Added A11y test for ILM new policy form. (elastic#92570) [Security Solution][Exceptions] - Fixes exceptions builder UI where invalid values can cause overwrites of other values (elastic#90634) Automatically generated Api documentation (elastic#86232) Increase index pattern select limit to 1000 (elastic#92093) [core.logging] Add RewriteAppender for filtering LogMeta. (elastic#91492) [Security Solution][Detection Rules] Update prebuilt rule threats to match schema (elastic#92281) [Security Solutions][Detection Engine] Fixes bug with not being able to duplicate indicator matches (elastic#92565) [Dashboard] Export appropriate references from byValue panels (elastic#91567) [Upgrade Assistant] Align code between branches (elastic#91862) [Security Solution][Case] Fix alerts push (elastic#91638) ...
This was referenced Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a dashboard has a
byValuepanel, since that panel is not backed by a saved object, any references from that panel should be added as a reference to the dashboard. This will ensure that the saved dashboard has the appropriate references for viewing relationships and exporting, etc.#82602 added inject/extract from embeddable plugin persistable state service, so this PR just adds the extract method to lens, maps, and visualize embeddable factories.
We will need to follow up on this, as the extract methods should alter the input with the references removed, but , we will need to come up with a way for the reference names to be unique since there could be many in a single dashboard. (Example: visualize always uses
'kibanaSavedObjectMeta.searchSourceJSON.index'as the reference name for it's index patterns, so if there were multiple visualizations, with multiple index-patterns, after extract we would not know how to put them back together since they have the same name)