Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Remove the Tour for the new 8.1 features #125504

Closed
banderror opened this issue Feb 14, 2022 · 2 comments · Fixed by #128398
Closed

[Security Solution][Detections] Remove the Tour for the new 8.1 features #125504

banderror opened this issue Feb 14, 2022 · 2 comments · Fixed by #128398
Assignees
@banderror
Labels
8.2 candidate considered, but not committed, for 8.2 release Feature:Rule Management Security Solution Detection Rule Management Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.2.0

Comments

@banderror
Copy link
Contributor

Epic: https://github.com/elastic/security-team/issues/1973

Summary

Remove the Tour UI we added to the Rule Management page for the new features introduced in 8.1: Bulk Editing and Experimental Sorting.

The Tour UI has been added in this PR: #124343
@banderror banderror added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management Team:Detection Rule Management Security Detection Rule Management Team v8.2.0 labels Feb 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@banderror banderror added the 8.2 candidate considered, but not committed, for 8.2 release label Feb 14, 2022
@banderror banderror mentioned this issue Mar 7, 2022
Closed
@banderror banderror self-assigned this Mar 10, 2022
@banderror banderror mentioned this issue Mar 23, 2022
Merged
@banderror banderror linked a pull request Mar 23, 2022 that will close this issue
[Security Solution][Detections] Removes the Tour for the new features on the Rule Management page introduced in 8.1 #128398
Merged
banderror added a commit that referenced this issue Mar 24, 2022
@banderror
[Security Solution][Detections] Removes the Tour for the new features…
0498f69 
… on the Rule Management page introduced in 8.1 (#128398)

**Ticket:** #125504

## Summary

This PR removes the Tour UI from components of the Rule Management page. We don't need to show `8.1` features in the `8.2.0` version. The Tour was previously introduced in #124343.

## Details

- The tour steps are removed from the components (`<EuiTourStep>`).
- The tour provider is removed from the page. It has been changed a little bit.
- I thought it could be useful to leave the implementation for now, in case we want to show new tours in the next versions. If we don't use it during the next few dev cycles given we will be shipping new features on the Rule Management page, we will need to completely remove it from the codebase.
- A short README is added with some notes on the Tour UI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@banderror banderror

Labels
8.2 candidate considered, but not committed, for 8.2 release Feature:Rule Management Security Solution Detection Rule Management Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.2.0
Projects
None yet
Milestone
No milestone
2 participants
@banderror @elasticmachine