Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up CasesContext #127335

Closed
angorayc opened this issue Mar 9, 2022 · 1 comment · Fixed by #130036
Closed

Clean up CasesContext #127335

angorayc opened this issue Mar 9, 2022 · 1 comment · Fixed by #130036
Assignees
@angorayc
Labels
Team:Threat Hunting:Explore

Comments

@angorayc
Copy link
Contributor

angorayc commented Mar 9, 2022

  • Wouldn't it make sense to move the <CasesContext> up to the HostsContainer and the NetworkContainer top-level components? So we will have cases available everywhere and we won't have to remember to wrap every single component that uses it? cc @stephmilovic
@angorayc angorayc self-assigned this Mar 9, 2022
@angorayc angorayc mentioned this issue Mar 9, 2022
Merged
2 tasks
@stephmilovic
Copy link
Contributor

Should we remove all CasesContexts in the app and have just one at x-pack/plugins/security_solution/public/app/index.tsx

@angorayc angorayc mentioned this issue Apr 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angorayc angorayc

Labels
Team:Threat Hunting:Explore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SecuritySolution] Clean up CaseContext angorayc/kibana
2 participants
@angorayc @stephmilovic