[Security Solution] Add visualization actions #126507

angorayc · 2022-02-28T19:27:45Z

Summary

Add vizualisation action component to bar chart, area chart, and matrix histogram.

Known issue:
In Security Solution we can filter index patterns under selected Data View in the Sourcerer, but when open the chart in Lens, it only takes all the index patterns under selected Data view id, to fix this, I append _index filter when open the chart in Lens as a temporary solution: #126911 (comment)
This inconsistency has also be written down in this issue and assigned to the relevant team: #126911

before:

previous_inspect.mp4

after:

Open In Lens

openInLens.mp4

Add to case & Inspect

custom_chart_actions.mp4

stephmilovic · 2022-03-14T19:17:27Z

x-pack/plugins/security_solution/public/network/components/kpi_network/common/index.tsx

- ))}
+ <CasesContext owner={[APP_ID]} userCanCrud={userCanCrud ?? false}>
+ {statItemsProps.map((mappedStatItemProps) => (
+ <StatItemsComponent {...mappedStatItemProps} showInspectButton={false} />


Warning: Each child in a list should have a unique "key" prop... is this not showing here? do we need a key?

The key prop is included in statItemsProps

stephmilovic

LGTM! I just had the question about the keys, not blocking. Great work!

YulNaumenko · 2022-03-14T19:41:34Z

x-pack/plugins/security_solution/kibana.json

@@ -18,6 +18,7 @@
 "eventLog",
 "features",
 "inspector",
+ "lens",


We have lens as an optionalPlugins also, can we add the dependency for a single place?

Yes, I've removed the optionalPlugins and keep it in requiredPlugins

YulNaumenko · 2022-03-14T19:46:09Z

x-pack/plugins/security_solution/public/common/components/alerts_viewer/histogram_configs.ts

@@ -30,4 +31,5 @@ export const histogramConfigs: MatrixHistogramConfigs = {
 stackByOptions: alertsStackByOptions,
 subtitle: undefined,
 title: i18n.ALERTS_GRAPH_TITLE,
+ getLensAttributes: getExternalAlertConfigs,


nit: Can we have a more consistent naming approach? Why the getExternalAlertConfigs is assigned to the property which seems to be a lens attributes - are we using a sub configuration? Maybe then we should assign here only the part of the config which is used for lens?

Yes, sorry for the confusion, getExternalAlertConfigs should be renamed to getExternalAlertLensAttributes as it is for getting Lens Attributes only. I've renamed all the Lens attributes and their folder.

YulNaumenko · 2022-03-14T21:23:56Z

x-pack/plugins/security_solution/public/common/components/header_section/index.tsx

@@ -97,7 +100,7 @@ const HeaderSectionComponent: React.FC<HeaderSectionProps> = ({
 )}
 </EuiFlexItem>

- {id && (
+ {id && showInspectButton && (


Can we test this with the unit test?

angorayc · 2022-03-15T09:26:58Z

/oblt-deploy

angorayc · 2022-03-15T12:56:11Z

@elasticmachine merge upstream

angorayc · 2022-03-15T13:33:35Z

@elasticmachine merge upstream

monina-n

all good from design thanks

angorayc · 2022-03-15T16:00:51Z

@elasticmachine merge upstream

…ions

YulNaumenko

Changes LGTM!
Please add the dev docs about how to create the lens visualization support to the new security visualization (we will need this later for the new stuff). It could be a follow up PR.

angorayc · 2022-03-15T17:28:42Z

Changes LGTM! Please add the dev docs about how to create the lens visualization support to the new security visualization (we will need this later for the new stuff). It could be a follow up PR.

Yup, thank you, added the readme here:
#126507 (review)

angorayc · 2022-03-15T18:27:23Z

@elasticmachine merge upstream

kibana-ci · 2022-03-15T21:52:36Z

💛 Build succeeded, but was flaky

Test Failures

[job] [logs] Security Solution Tests / risk tab "before all" hook for "renders risk tab"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2902	2931	+29

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	4.7MB	4.7MB	+49.8KB

History

💔 Build #30627 failed 66e2490
💔 Build #30468 failed 060484c
💔 Build #30431 failed db3ffac
💔 Build #30376 failed 08ffdf9
💚 Build #30062 succeeded dc46b4c
💔 Build #30023 failed cf1ae9d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc

* add chart configs * init hosts chart actions * init network chart actions * add to new case * clean up * clean up * clean up configs * rename configs * rename histogram actions to viz actions component * fix up * add vizType * cypress hosts inspect * add viz actions cypress tests * fix type * stat_items unit test * fix unit tests for alerts by category * fix unit tests * unit tests * unit tests * rename vizType from store to inspectedVizType * move out i18n * unit test * add index filter * clean up configs * unit tests * fix typo * rm unused props * apply cases flyout and modal * rm unused definition * fix typo * rm vizType in reducer * onCloseInspect callback * move viz action component out of header section * rm hard coded dataViewId in configs * update icon and wording * fix unit tests * useRouteSpy * showInspectButton * add aria label * rm type casting * unit test * rm id from filters * use mockCasesContract * add unit tests * styling * update mock * rm visualization actions cypress tests * clean up data-test-subj * disabled inspect button in matrix histogram by default * styling * viz actions only available on hosts / network page * rm kpi * unit tests * unit tests * unit tests * unit tests * kibana dependency * rename * add readme Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

angorayc added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore v8.2.0 labels Feb 28, 2022

spalger force-pushed the main branch from 29879e2 to 8fc81f4 Compare February 28, 2022 19:34

angorayc added 7 commits March 1, 2022 03:42

add chart configs

0cc92f6

init hosts chart actions

9c0d996

init network chart actions

2a70a70

add to new case

038e4c3

clean up

6698b73

clean up

e666488

clean up configs

b951e07

angorayc force-pushed the viz_actions branch from cd02303 to b951e07 Compare February 28, 2022 19:44

spalger force-pushed the main branch from 4fdb2d9 to 50e8972 Compare February 28, 2022 19:47

angorayc added 6 commits March 1, 2022 18:12

rename configs

753e0d6

rename histogram actions to viz actions component

7435652

fix up

32d9c80

add vizType

0c7cbcb

cypress hosts inspect

fb711a1

add viz actions cypress tests

2b1eb95

angorayc changed the title ~~[Security Solution] Viz actions~~ [Security Solution] Add visualization actions Mar 2, 2022

angorayc mentioned this pull request Mar 2, 2022

[Security Solution] Open charts in Lens #124792

Closed

34 tasks

angorayc self-assigned this Mar 2, 2022

angorayc added 7 commits March 3, 2022 02:34

fix type

2301e5b

stat_items unit test

4bafba5

fix unit tests for alerts by category

b042b03

fix unit tests

8da3ccc

unit tests

3bc029f

unit tests

11f56a8

rename vizType from store to inspectedVizType

fc45201

unit tests

dc46b4c

stephmilovic reviewed Mar 14, 2022

View reviewed changes

stephmilovic approved these changes Mar 14, 2022

View reviewed changes

YulNaumenko reviewed Mar 14, 2022

View reviewed changes

angorayc added 3 commits March 15, 2022 17:46

unit tests

96ed710

kibana dependency

1ed177e

rename

08ffdf9

cnasikas mentioned this pull request Mar 15, 2022

[Cases] Allow external plugins to add content to the cases markdown editor #127734

Open

5 tasks

Merge branch 'main' into viz_actions

db3ffac

Merge branch 'main' into viz_actions

060484c

monina-n approved these changes Mar 15, 2022

View reviewed changes

kibanamachine and others added 3 commits March 15, 2022 12:01

Merge branch 'main' into viz_actions

e1ae8a4

add readme

5ddb9eb

Merge branch 'viz_actions' of github.com:angorayc/kibana into viz_act…

66e2490

…ions

YulNaumenko approved these changes Mar 15, 2022

View reviewed changes

angorayc enabled auto-merge (squash) March 15, 2022 17:23

Merge branch 'main' into viz_actions

6ade15f

angorayc merged commit 692ca00 into elastic:main Mar 15, 2022

angorayc added the backport:skip This commit does not require backporting label Mar 16, 2022

cee-chen mentioned this pull request Apr 14, 2022

[Security Solution] Inspect icon is not working in show top modal under alert page #128626

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Add visualization actions #126507

[Security Solution] Add visualization actions #126507

angorayc commented Feb 28, 2022 •

edited

Loading

stephmilovic Mar 14, 2022

angorayc Mar 14, 2022

stephmilovic left a comment

YulNaumenko Mar 14, 2022 •

edited

Loading

angorayc Mar 15, 2022

YulNaumenko Mar 14, 2022

angorayc Mar 15, 2022

YulNaumenko Mar 14, 2022

angorayc Mar 15, 2022

angorayc commented Mar 15, 2022

angorayc commented Mar 15, 2022

angorayc commented Mar 15, 2022

monina-n left a comment

angorayc commented Mar 15, 2022

YulNaumenko left a comment

angorayc commented Mar 15, 2022

angorayc commented Mar 15, 2022

kibana-ci commented Mar 15, 2022

[Security Solution] Add visualization actions #126507

[Security Solution] Add visualization actions #126507

Conversation

angorayc commented Feb 28, 2022 • edited Loading

Summary

stephmilovic Mar 14, 2022

Choose a reason for hiding this comment

angorayc Mar 14, 2022

Choose a reason for hiding this comment

stephmilovic left a comment

Choose a reason for hiding this comment

YulNaumenko Mar 14, 2022 • edited Loading

Choose a reason for hiding this comment

angorayc Mar 15, 2022

Choose a reason for hiding this comment

YulNaumenko Mar 14, 2022

Choose a reason for hiding this comment

angorayc Mar 15, 2022

Choose a reason for hiding this comment

YulNaumenko Mar 14, 2022

Choose a reason for hiding this comment

angorayc Mar 15, 2022

Choose a reason for hiding this comment

angorayc commented Mar 15, 2022

angorayc commented Mar 15, 2022

angorayc commented Mar 15, 2022

monina-n left a comment

Choose a reason for hiding this comment

angorayc commented Mar 15, 2022

YulNaumenko left a comment

Choose a reason for hiding this comment

angorayc commented Mar 15, 2022

angorayc commented Mar 15, 2022

kibana-ci commented Mar 15, 2022

💛 Build succeeded, but was flaky

Test Failures

Metrics [docs]

Module Count

Async chunks

History

angorayc commented Feb 28, 2022 •

edited

Loading

YulNaumenko Mar 14, 2022 •

edited

Loading