Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing a full round trip to RequestHandler when setting a vis.uiState value #12781

Closed
thomasneirynck opened this issue Jul 11, 2017 · 1 comment · Fixed by #12752
Closed
Assignees
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) PR sent release_note:enhancement v6.0.0

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Jul 11, 2017

Using the vis-object to set a uiState value, no full round trip to the requestHandler is triggered.

Consider giving clients an opportunity to trigger a round trip to the requestHandler. This could be useful when you have want to have session-specific configs that you do not want to persist with the visualization itself. An example of this could be the sort-order of a table-column for a paginated table-component.

The vis.updateState method is not a good fit for this use-case. It only triggers a data round-trip when the vis.params change. For example, the maps can force-trigger a refresh like this when the zoom level changes, but only because the associated precision for the agg_configs changes as well.

Another option would be to give users the means to manually force-refresh. For example. by calling something like vis.forceRefresh().

@thomasneirynck thomasneirynck added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement v6.0.0 labels Jul 11, 2017
@thomasneirynck
Copy link
Contributor Author

cc @simianhacker @ppisljar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) PR sent release_note:enhancement v6.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants