fixing refresh and auto refresh

[ppisljar]

closes #12733
closes #12781

[thomasneirynck]

Works well, except clicking the magnifying glass next to the query-bar does not refresh the data.

In hindsight, I'm not sure if the should refresh the data to begin with. It would mean we have two buttons (search and refresh) that do exactly the same.

I'm not sure if the search-button from the query-bar should govern the entire page, as it's not related to the time-picker or the filter-bar.

[ppisljar]

i agree, that magnifying glass should only submit a query right ?

[nreese]

@ppisljar In the visualize directive, the stateMonitor is not getting properly cleaned up. It should be destroyed when the scope gets destroyed.

Also, I think maps_visualization could benefit from this PR. Before the vis refactor, zoomend used to manually trigger a courier.fetch. Now zoomend just updates the state which I assume is used to trigger a refetch. I think it would be clearer if zoomend just triggered reload.

This will help me with Filter geohash_grid aggregation to map view box with collar. I need to trigger a fetch when the map view box is outside of the map collar and having to do this via saving the state is a little more difficult

[ppisljar]

@nreese visualization should never directly trigger a reload ... doing vis.emit('reload') does the same as doing the vis.updateState() ... it just notifies that it should do something ....
in case of updateState it will check if it needs to refetch data and such, in reload it will force refetch data.

[ppisljar]

uiState now triggers normal reload path (calling scope.fetch()) ....
courier response handler already knows uiState does not affect it and will not call es (unless forceReload() is used), but this gives possibility to other request handlers (like tsvb) to handle this differently

[ppisljar]

jenkins, test this

[thomasneirynck]

pressing the magnifier on the dashboard doesn't work. Consider adding

  $scope.vis.on('reload', reload);
      $scope.$on('courier:searchRefresh', reload);
      $scope.$on('fetch', () => {
        console.log('fetching on command from dashboard.js');
        $scope.vis.forceReload();
      });

[thomasneirynck]

apart from dashboard issue, LGTM.

[jimgoodwin]

@ppisljar Please add a Release Note: paragraph to the description that describes what changed please

[thomasneirynck]

Removing release_note:fix label. This fixed a regression introduced by the refactor in master, but should not affect any user of v5. So I think we can skip the release note here.