Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visualize should send ready:vis event when done #12796

Merged
merged 1 commit into from
Jul 12, 2017
Merged

visualize should send ready:vis event when done #12796

merged 1 commit into from
Jul 12, 2017

Conversation

ppisljar
Copy link
Member

closes #12782

@ppisljar ppisljar added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v6.0.0 labels Jul 12, 2017
@ppisljar ppisljar merged commit dee4f7d into elastic:master Jul 12, 2017
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Jul 12, 2017
@thomasneirynck
Revert "sending ready:vis event when done (elastic#12796)"
9c76c36 
This reverts commit dee4f7d.
thomasneirynck added a commit that referenced this pull request Jul 12, 2017
@thomasneirynck
Revert "sending ready:vis event when done (#12796)" (#12799)
fcee78a 
This reverts commit dee4f7d.

This needs some more review, as in-tandem with the refresh PR, #12752, it may introduce some unwanted side-effects.
@thomasneirynck thomasneirynck mentioned this pull request Jul 12, 2017
Closed
@thomasneirynck
Copy link
Contributor

thomasneirynck commented Jul 12, 2017 •
edited
Loading

I reverted this (#12799). I think it caused infinite loops, in tandem with the refresh PR (#12752). Let's look at it closely.

thomasneirynck pushed a commit to thomasneirynck/kibana that referenced this pull request Jul 12, 2017
@ppisljar @thomasneirynck
sending ready:vis event when done (elastic#12796)
bd89026
@thomasneirynck thomasneirynck mentioned this pull request Jul 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese Awaiting requested review from nreese

@thomasneirynck thomasneirynck Awaiting requested review from thomasneirynck

Assignees
No one assigned
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix review v6.0.0-rc1 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty search when adding a vis then a search to a dashboard
3 participants
@ppisljar @thomasneirynck @jimgoodwin