Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save and return not valid as a top bar menu option for histogram lens viz from discover #128695

Closed
bhavyarm opened this issue Mar 28, 2022 · 4 comments · Fixed by #129053
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week Feature:Lens Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. :VisEditors:fix-it-week

Comments

@bhavyarm
Copy link
Contributor

Kibana version: 8.2.0 snapshot

Elasticsearch version: 8.2.0 snapshot

Server OS version: darwin_x96_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from snapshots

Describe the bug: If user clicks on create viz (create lens) from discover histogram and then in lens clicks save and return - Kibana navigates user back to discover but lens viz doesn't get saved.

save.return.mp4
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Lens Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Mar 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@ghudgins
Copy link
Contributor

I think the desired behavior would be:

Given a user is in discover
When they click "Visualize in Lens"
Then they see "Save" is the option (the "and return" only applies when coming from Dashboard context)
And When they click "Save"
Then the user sees the dashboard save modal as if the visualization is new

We will clean up the "return to Discover" via the "Explore raw data" options in the short term and #124584 in the medium term (hopefully)

CC @MichaelMarcialis & @ryankeairns for their thoughts on the above proposal to fix this

@ryankeairns
Copy link
Contributor

+1 @ghudgins - let's leverage that Save modal that steers them toward adding the viz to a dashboard.

@MichaelMarcialis
Copy link
Contributor

CC @MichaelMarcialis & @ryankeairns for their thoughts on the above proposal to fix this

This makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week Feature:Lens Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. :VisEditors:fix-it-week
Projects
None yet
7 participants