Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "Save and return" button with "Save" for Lens visualization created from Discover histogram or visualised field to avoid confusion #129053

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Replace "Save and return" button with "Save" for Lens visualization created from Discover histogram or visualised field to avoid confusion #129053

merged 4 commits into from
Apr 6, 2022

Conversation

DianaDerevyankina
Copy link
Contributor

@DianaDerevyankina DianaDerevyankina commented Mar 31, 2022 •
edited
Loading

Closes #128695

Summary

Lens visualization created from Discover histogram or from visualised field instead of displaying "Save as...." and "Save and return" buttons now contains only "Save" one for adding it to a library or to a dashboard.

lens from discover save and return replaced with save

lens field from discover save and return replaced with save

@DianaDerevyankina
Replace "Save and return" button with "Save" for Lens visualization c…
05064c6 
…reated from Discover histogram to avoid confusion
@DianaDerevyankina DianaDerevyankina added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v8.2.0 labels Mar 31, 2022
@DianaDerevyankina DianaDerevyankina self-assigned this Mar 31, 2022
alexwizp
alexwizp approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DianaDerevyankina DianaDerevyankina marked this pull request as ready for review April 5, 2022 10:08
@DianaDerevyankina DianaDerevyankina requested a review from a team as a code owner April 5, 2022 10:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@DianaDerevyankina
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Contributor

@dziyanadzeraviankina I was testing your PR and works great but I found out that we have the same bug when we are hitting Visualize in Discover and navigate to Lens.

image

Do you want to also take a look on that as it is on the same context? We can do it on another PR of course.

@stratoula stratoula added auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 labels Apr 5, 2022
@kertal
Copy link
Member

kertal commented Apr 5, 2022

Do you want to also take a look on that as it is on the same context? We can do it on another PR of course.

Fix looks good to me, adding the other issue to this PR would kind of simplify the code since the function would not need an additional parameter anymore.

@DianaDerevyankina DianaDerevyankina changed the title Replace "Save and return" button with "Save" for Lens visualization created from Discover histogram to avoid confusion Replace "Save and return" button with "Save" for Lens visualization created from Discover histogram or visualised field to avoid confusion Apr 6, 2022
kertal
kertal approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in Chrome, MacOs, works as expected, thx for fixing this 👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
discover 61 60 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 400.4KB 400.3KB -24.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 50.7KB 50.7KB -52.0B
Unknown metric groups

API count

id before after diff
discover 77 76 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@DianaDerevyankina DianaDerevyankina merged commit db67505 into elastic:main Apr 6, 2022
kibanamachine pushed a commit that referenced this pull request Apr 6, 2022
@DianaDerevyankina
Replace "Save and return" button with "Save" for Lens visualization c…
d9ecdc4 
…reated from Discover histogram or visualised field to avoid confusion (#129053)

* Replace "Save and return" button with "Save" for Lens visualization created from Discover histogram to avoid confusion

* Remove passing originatingApp as trigger options at all to replace "Save and return" with "Save" for the field visualized from Discover

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit db67505)
@kibanamachine kibanamachine mentioned this pull request Apr 6, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 6, 2022
@kibanamachine @DianaDerevyankina
Replace "Save and return" button with "Save" for Lens visualization c…
ef687d7 
…reated from Discover histogram or visualised field to avoid confusion (#129053) (#129573)

* Replace "Save and return" button with "Save" for Lens visualization created from Discover histogram to avoid confusion

* Remove passing originatingApp as trigger options at all to replace "Save and return" with "Save" for the field visualized from Discover

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit db67505)

Co-authored-by: Diana Derevyankina <54894989+DziyanaDzeraviankina@users.noreply.github.com>
@jughosta jughosta mentioned this pull request Jun 7, 2022
Closed
@nreese nreese mentioned this pull request Jul 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@kertal kertal kertal approved these changes

@VladLasitsa VladLasitsa Awaiting requested review from VladLasitsa

Assignees

@DianaDerevyankina DianaDerevyankina

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.0 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save and return not valid as a top bar menu option for histogram lens viz from discover
7 participants
@DianaDerevyankina @elasticmachine @stratoula @kertal @kibana-ci @kibanamachine @alexwizp