Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Save and return" button with "Save" for Lens visualization created from Discover histogram or visualised field to avoid confusion #129053

Merged
merged 4 commits into from
Apr 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/plugins/discover/common/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
* Side Public License, v 1.
*/

export const APP_ID = 'discover';
export const DEFAULT_COLUMNS_SETTING = 'defaultColumns';
export const SAMPLE_SIZE_SETTING = 'discover:sampleSize';
export const SORT_DEFAULT_ORDER_SETTING = 'discover:sort:defaultOrder';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import {
import { getUiActions } from '../../../../../kibana_services';
import type { DataViewField } from '../../../../../../../data_views/public';
import { KBN_FIELD_TYPES } from '../../../../../../../data/public';
import { APP_ID } from '../../../../../../common';

function getTriggerConstant(type: string) {
return type === KBN_FIELD_TYPES.GEO_POINT || type === KBN_FIELD_TYPES.GEO_SHAPE
Expand Down Expand Up @@ -54,7 +53,6 @@ export function triggerVisualizeActions(
indexPatternId,
fieldName: field.name,
contextualFields,
originatingApp: APP_ID,
};
getUiActions().getTrigger(trigger).exec(triggerOptions);
}
Expand Down