Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Creating visualizations from Discover page works differently depending on a context in Dashboard #133721

Closed
jughosta opened this issue Jun 7, 2022 · 8 comments
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@jughosta
Copy link
Contributor

jughosta commented Jun 7, 2022

Kibana version: 8.3

Description of the problem including expected versus actual behavior:
Creating a visualization from Discover histogram works differently depending on a current context (whether a user already started creating a dashboard or not). Question: is it a feature or a bug?

Steps to reproduce:
Case 1: if user went to Discover directly, pressed "Edit visualization", it will open “Visualize Library > Create” page + “Save” button
Case 2: if user started creating a Dashboard and a visualization but interrupted it by going to Discover and pressing “Edit visualization”, it will open “Dashboard > Create” page + “Save and return” button

Jun-07-2022 11-19-32

Noticed while testing #129053

@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 7, 2022
@jughosta jughosta added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jun 7, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 7, 2022
@flash1293
Copy link
Contributor

Good question - @elastic/kibana-presentation team, what do you think about this?

@teresaalvarezsoler
Copy link

I think it's a feature... In the Case 2 we assumed the user wants to save the visualization in the last opened dashboard.

@ThomThomson
Copy link
Contributor

In short, I agree with Teresa that this seems more like a feature, but I want to go a little bit deeper because I think this depends on where we draw the line that defines a user's session.

We've previously considered that if a user navigates via the nav drawer rather than via links / drilldowns in the apps, that it ends their session and starts a new one. In that case, the minute the user clicks discover from the Lens page, they will have left their session behind, which would mean forgetting that they were building a dashboard earlier. In this case though, it seems as though the originatingApp is either forwarded to discover then back to lens, or is stored separately in Lens, even though the user navigated through the nav drawer.

I think that navigating via the nav drawer and navigating through a button on the page should be treated the same, and only specific drilldowns registered on data click should come with special behaviour.

@jughosta
Copy link
Contributor Author

jughosta commented Jun 8, 2022

An issue with Case 2 could be that user can't select a dashboard where to put their new visualization. It will be simply added to the active dashboard.

@teresaalvarezsoler
Copy link

If we assume this is the desired behavior by users at least 80% of the times, then this is the correct UX. Otherwise we will be introducing an additional annoying step for most users most of the times.

Did we receive any feedback in the past from users that this is not desired? You could also look at the metrics in Full Story if you consider this is important.

@jughosta
Copy link
Contributor Author

jughosta commented Jun 9, 2022

Thanks for looking into it! Feel free to close the issue.
I think #134017 could improve UX a little here.

@teresaalvarezsoler
Copy link

Good point, closing the issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

5 participants