Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.2] Replace "Save and return" button with "Save" for Lens visualization created from Discover histogram or visualised field to avoid confusion (#129053) #129573

Merged
merged 1 commit into from
Apr 6, 2022
Merged

[8.2] Replace "Save and return" button with "Save" for Lens visualization created from Discover histogram or visualised field to avoid confusion (#129053) #129573

merged 1 commit into from
Apr 6, 2022

Conversation

kibanamachine
Copy link
Contributor

@DianaDerevyankina
Replace "Save and return" button with "Save" for Lens visualization c…
d9ecdc4 
…reated from Discover histogram or visualised field to avoid confusion (#129053)

* Replace "Save and return" button with "Save" for Lens visualization created from Discover histogram to avoid confusion

* Remove passing originatingApp as trigger options at all to replace "Save and return" with "Save" for the field visualized from Discover

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit db67505)
@kibanamachine kibanamachine enabled auto-merge (squash) April 6, 2022 10:50
@kibanamachine kibanamachine mentioned this pull request Apr 6, 2022
Merged
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
discover 61 60 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 383.5KB 383.5KB -24.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 50.5KB 50.4KB -52.0B
Unknown metric groups

API count

id before after diff
discover 77 76 -1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine kibanamachine merged commit ef687d7 into 8.2 Apr 6, 2022
@kibanamachine kibanamachine deleted the backport/8.2/pr-129053 branch April 6, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DianaDerevyankina DianaDerevyankina

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @kibana-ci @DianaDerevyankina