Skip to content

Commit

Permalink
Replace "Save and return" button with "Save" for Lens visualization c…
Browse files Browse the repository at this point in the history
…reated from Discover histogram or visualised field to avoid confusion (#129053)

* Replace "Save and return" button with "Save" for Lens visualization created from Discover histogram to avoid confusion

* Remove passing originatingApp as trigger options at all to replace "Save and return" with "Save" for the field visualized from Discover

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit db67505)
  • Loading branch information
DianaDerevyankina committed Apr 6, 2022
1 parent 8edbb89 commit d9ecdc4
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion src/plugins/discover/common/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
* Side Public License, v 1.
*/

export const APP_ID = 'discover';
export const DEFAULT_COLUMNS_SETTING = 'defaultColumns';
export const SAMPLE_SIZE_SETTING = 'discover:sampleSize';
export const SORT_DEFAULT_ORDER_SETTING = 'discover:sort:defaultOrder';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import {
import { getUiActions } from '../../../../../kibana_services';
import type { DataViewField } from '../../../../../../../data_views/public';
import { KBN_FIELD_TYPES } from '../../../../../../../data/public';
import { APP_ID } from '../../../../../../common';

function getTriggerConstant(type: string) {
return type === KBN_FIELD_TYPES.GEO_POINT || type === KBN_FIELD_TYPES.GEO_SHAPE
Expand Down Expand Up @@ -54,7 +53,6 @@ export function triggerVisualizeActions(
indexPatternId,
fieldName: field.name,
contextualFields,
originatingApp: APP_ID,
};
getUiActions().getTrigger(trigger).exec(triggerOptions);
}
Expand Down

0 comments on commit d9ecdc4

Please sign in to comment.